Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #3046 - Failures converting data to VDC format #3051

Merged
merged 5 commits into from
Feb 24, 2022
Merged

Fixed #3046 - Failures converting data to VDC format #3051

merged 5 commits into from
Feb 24, 2022

Conversation

clyne
Copy link
Collaborator

@clyne clyne commented Feb 23, 2022

Fixed #3046

@clyne
Changed NetCDFCpp::DefVar to not return an error if the same variable is
629c8e2 
defined twice, but with the same definition.
@clyne
Fixed #3046 - Failures converting data to VDC format
fa5929b 
VDC library wasn't supporting variables that not compressed, but had
missing values.
@clyne
clang-format pre-push hook
80a7a5b
StasJ
StasJ approved these changes Feb 23, 2022
View reviewed changes
include/vapor/VDC.h Outdated Show resolved Hide resolved
@clyne clyne requested a review from StasJ February 23, 2022 23:57
@clyne clyne unassigned StasJ and sgpearse Feb 23, 2022
@clyne clyne requested a review from sgpearse February 23, 2022 23:57
@clyne
Copy link
Collaborator Author

clyne commented Feb 23, 2022

@sgpearse , @sgpearse I mistakenly added you as "assignees" earlier. I've change to "reviewers"

@sgpearse
Copy link
Collaborator

sgpearse commented Feb 24, 2022 •
edited

@clyne I'm encountering the following cfvdccreate error on the POP/BryanASP/one_degree/daily
dataset. Are you able to reproduce this?

Tested on 524915a with casper. Build is created on /glade/u/home/pearse/VAPOR.

Command:

-bash-4.2$ ./bin/cfvdccreate /glade/p/cisl/vast/vapor/data/Source/POP/BryanASP/one_degree/daily/*.nc /glade/scratch/pearse/bug3046/BryanASP/one_degree/oneDegree.vdc

Error:

Error accessing netCDF file "/glade/scratch/pearse/bug3046/BryanASP/one_degree/oneDegree.vdc", nc_def_var(dz) : NetCDF: String match to name in use -- file

(/glade/u/home/pearse/VAPOR/lib/wasp/NetCDFCpp.cpp), line(113)
Failed to write VDC master file : /glade/scratch/pearse/bug3046/BryanASP/one_degree/oneDegree.vdc

@clyne
Copy link
Collaborator Author

clyne commented Feb 24, 2022

I am not able to reproduce this. Did you do a clean build?

@clyne
Copy link
Collaborator Author

clyne commented Feb 24, 2022

@sgpearse that is the wrong hash. It should be 7db9170

@sgpearse
Copy link
Collaborator

@clyne - Thanks - retesting now.

@clyne clyne merged commit bbf18a5 into main Feb 24, 2022
@clyne clyne deleted the issue_3046 branch February 24, 2022 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StasJ StasJ StasJ approved these changes

@sgpearse sgpearse sgpearse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failures converting data to VDC format
3 participants
@clyne @sgpearse @StasJ