Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particle dynamic size #3550

Merged
merged 3 commits into from Mar 14, 2024
Merged

Particle dynamic size #3550

merged 3 commits into from Mar 14, 2024

Conversation

StasJ
Copy link
Collaborator

@StasJ StasJ commented Feb 28, 2024

This PR depends on #3541

s

@StasJ
Copy link
Collaborator Author

StasJ commented Mar 11, 2024

CI failing due to google drive limits.

@NihanthCW NihanthCW requested a review from shaomeng March 12, 2024 22:43
Copy link
Collaborator

@shaomeng shaomeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good mostly, with a few minor questions.

The testing data set, /glade/derecho/scratch/drichter/CM1LP_dev/debug_mult_problem/vapor_files, doesn't seem to be available on glade though. Is it possible to test using another data set?

lib/render/ParticleRenderer.cpp Show resolved Hide resolved
lib/render/ParticleRenderer.cpp Show resolved Hide resolved
@@ -284,6 +288,7 @@ int ParticleRenderer::_renderParticlesHelper()
shader->SetUniform("MV", _glManager->matrixManager->GetModelViewMatrix());
shader->SetUniform("aspect", _glManager->matrixManager->GetProjectionAspectRatio());
shader->SetUniform("radius", radius);
// shader->SetUniform("radiusVarStrength", (float)rp->GetValueDouble(ParticleParams::RenderRadiusVariableStrengthTag, 1.));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete it?

@shaomeng shaomeng self-requested a review March 14, 2024 18:41
@NihanthCW NihanthCW merged commit 991dcb0 into main Mar 14, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants