Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve particle renderer performance 12,500x #3541

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Improve particle renderer performance 12,500x #3541

merged 1 commit into from
Mar 1, 2024

Conversation

StasJ
Copy link
Collaborator

@StasJ StasJ commented Feb 20, 2024

This PR makes the particle renderer over 12,500 times faster. Below Vapor is rendering over 20,000,000 particles in realtime. This PR also drastically decreases both its CPU and GPU RAM requirements.

performance

@StasJ StasJ mentioned this pull request Feb 28, 2024
Merged
sgpearse
sgpearse approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@sgpearse sgpearse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting use of static functions for openGL setup. That makes sense. Interesting use of goto as well. I avoid it because of stigma but the new code does read easily with it.

@sgpearse sgpearse merged commit 96c04e4 into main Mar 1, 2024
2 checks passed
@StasJ StasJ deleted the particle_performance branch July 17, 2024 05:39
@sgpearse sgpearse mentioned this pull request Aug 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgpearse sgpearse sgpearse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StasJ @sgpearse