Fix error message for unit conversions involving unit "1" #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkavulich
requested review from
climbfuji,
grantfirl and
gold2718
as code owners
climbfuji
approved these changes
Feb 28, 2023
grantfirl
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #458, there is a problem with the unit converter if
attempting to convert from unit "1" to any other value: while this
should result in an error (units of "1" can't be converted to anything
else), the error that results is not descriptive (due to "1" not being a
valid python function name). This change adds an if statement to
correctly pass "1" as a valid unit so that the correct error message
is printed.
User interface changes?: No
Fixes: #458 Unit converter does not handle units = 1 correctly for incompatible conversions
Testing:
test removed: None
unit tests: All existing passed. Added new unit test for validating the string_to_python_identifier() function for both valid and invalid inputs
system tests: None
manual testing: Ran ccpp_prebuild with SCM with a modified metadata file to confirm both error and fix (posted comment in issue with more details).