Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSD drag suite and GSD SAR regresssion tests not bit-for-bit identical in CCPP dynamic mode #331

Closed
climbfuji opened this issue Oct 7, 2019 · 3 comments
Closed

GSD drag suite and GSD SAR regresssion tests not bit-for-bit identical in CCPP dynamic mode #331

climbfuji opened this issue Oct 7, 2019 · 3 comments
Assignees
@climbfuji @mdtoy

Comments

@climbfuji
Copy link
Collaborator

The newly added test fv3_ccpp_gsd_drag_suite gives different results in REPRO mode when CCPP is compiled in dynamic mode:

baseline dir = /scratch1/BMC/gmtb/Dom.Heinzeller/FV3_RT/REGRESSION_TEST_GSD/fv3_gsd_drag_suite_repro
working dir  = /scratch1/BMC/gmtb/Dom.Heinzeller/FV3_RT/rt_129286/fv3_ccpp_gsd_drag_suite_repro
Checking test 20 fv3_ccpp_gsd_drag_suite results ....
 Comparing atmos_4xdaily.tile1.nc ............NOT OK
 Comparing atmos_4xdaily.tile2.nc ............NOT OK
 Comparing atmos_4xdaily.tile3.nc ............NOT OK
 Comparing atmos_4xdaily.tile4.nc ............NOT OK
 Comparing atmos_4xdaily.tile5.nc ............NOT OK
 Comparing atmos_4xdaily.tile6.nc ............NOT OK
 Comparing phyf000.tile1.nc ............NOT OK
 Comparing phyf000.tile2.nc ............NOT OK
 Comparing phyf000.tile3.nc ............NOT OK
 Comparing phyf000.tile4.nc ............NOT OK
 Comparing phyf000.tile5.nc ............NOT OK
 Comparing phyf000.tile6.nc ............NOT OK
 Comparing phyf024.tile1.nc ............NOT OK
 Comparing phyf024.tile2.nc ............NOT OK
 Comparing phyf024.tile3.nc ............NOT OK
 Comparing phyf024.tile4.nc ............NOT OK
 Comparing phyf024.tile5.nc ............NOT OK
 Comparing phyf024.tile6.nc ............NOT OK
 Comparing dynf000.tile1.nc ............NOT OK
 Comparing dynf000.tile2.nc ............NOT OK
 Comparing dynf000.tile3.nc ............NOT OK
 Comparing dynf000.tile4.nc ............NOT OK
 Comparing dynf000.tile5.nc ............NOT OK
 Comparing dynf000.tile6.nc ............NOT OK
 Comparing dynf024.tile1.nc ............NOT OK
 Comparing dynf024.tile2.nc ............NOT OK
 Comparing dynf024.tile3.nc ............NOT OK
 Comparing dynf024.tile4.nc ............NOT OK
 Comparing dynf024.tile5.nc ............NOT OK
 Comparing dynf024.tile6.nc ............NOT OK
 Comparing RESTART/coupler.res .........OK
 Comparing RESTART/fv_core.res.nc .........OK
 Comparing RESTART/fv_core.res.tile1.nc ............NOT OK
 Comparing RESTART/fv_core.res.tile2.nc ............NOT OK
 Comparing RESTART/fv_core.res.tile3.nc ............NOT OK
 Comparing RESTART/fv_core.res.tile4.nc ............NOT OK
 Comparing RESTART/fv_core.res.tile5.nc ............NOT OK
 Comparing RESTART/fv_core.res.tile6.nc ............NOT OK
 Comparing RESTART/fv_srf_wnd.res.tile1.nc ............NOT OK
 Comparing RESTART/fv_srf_wnd.res.tile2.nc ............NOT OK
 Comparing RESTART/fv_srf_wnd.res.tile3.nc ............NOT OK
 Comparing RESTART/fv_srf_wnd.res.tile4.nc ............NOT OK
 Comparing RESTART/fv_srf_wnd.res.tile5.nc ............NOT OK
 Comparing RESTART/fv_srf_wnd.res.tile6.nc ............NOT OK
 Comparing RESTART/fv_tracer.res.tile1.nc ............NOT OK
 Comparing RESTART/fv_tracer.res.tile2.nc ............NOT OK
 Comparing RESTART/fv_tracer.res.tile3.nc ............NOT OK
 Comparing RESTART/fv_tracer.res.tile4.nc ............NOT OK
 Comparing RESTART/fv_tracer.res.tile5.nc ............NOT OK
 Comparing RESTART/fv_tracer.res.tile6.nc ............NOT OK
 Comparing RESTART/phy_data.tile1.nc ............NOT OK
 Comparing RESTART/phy_data.tile2.nc ............NOT OK
 Comparing RESTART/phy_data.tile3.nc ............NOT OK
 Comparing RESTART/phy_data.tile4.nc ............NOT OK
 Comparing RESTART/phy_data.tile5.nc ............NOT OK
 Comparing RESTART/phy_data.tile6.nc ............NOT OK
 Comparing RESTART/sfc_data.tile1.nc ............NOT OK
 Comparing RESTART/sfc_data.tile2.nc ............NOT OK
 Comparing RESTART/sfc_data.tile3.nc ............NOT OK
 Comparing RESTART/sfc_data.tile4.nc ............NOT OK
 Comparing RESTART/sfc_data.tile5.nc ............NOT OK
 Comparing RESTART/sfc_data.tile6.nc ............NOT OK
Test 20 fv3_ccpp_gsd_drag_suite FAIL
@mdtoy
Copy link
Collaborator

mdtoy commented Oct 7, 2019

Dom,

I noticed this on Friday when I ran RT's myself. I wasn't sure if it was an issue or not, but I guess it is. Please let me know if the ball is now in my court to figure out what's going on.

Thanks.

-- Mike

@climbfuji
Copy link
Collaborator Author

climbfuji commented Nov 27, 2019 •
edited
Loading

Similar for the newly added GSD SAR test, although in this case it could be for a different reason (hitting the walltime?).

bash-4.2$ cat log_hera.intel/rt_23_fv3_ccpp_gsd_sar_repro.log

baseline dir = /scratch1/BMC/gmtb/Dom.Heinzeller/FV3_RT/REGRESSION_TEST_GSD/fv3_gsd_sar_repro
working dir  = /scratch1/BMC/gmtb/Dom.Heinzeller/FV3_RT/rt_453795/fv3_ccpp_gsd_sar_repro
Checking test 23 fv3_ccpp_gsd_sar results ....
 Comparing atmos_4xdaily.nc .........OK
 Comparing dynf000.nc .........OK
 Comparing dynf003.nc .........OK
 Comparing phyf000.nc .........OK
 Comparing phyf003.nc .........OK
 Comparing RESTART/coupler.res ............MISSING file
 Comparing RESTART/fv_core.res.nc ............MISSING file
 Comparing RESTART/fv_core.res.tile1.nc ............MISSING file
 Comparing RESTART/fv_srf_wnd.res.tile1.nc ............MISSING file
 Comparing RESTART/fv_tracer.res.tile1.nc ............MISSING file
 Comparing RESTART/phy_data.nc ............MISSING file
 Comparing RESTART/sfc_data.nc ............MISSING file
Test 23 fv3_ccpp_gsd_sar FAIL

@climbfuji climbfuji changed the title GSD drag suite regresssion test not bit-for-bit identical in CCPP dynamic mode GSD drag suite and GSD SAR regresssion tests not bit-for-bit identical in CCPP dynamic mode Nov 27, 2019
@climbfuji climbfuji mentioned this issue Nov 27, 2019
Merged
@climbfuji
Copy link
Collaborator Author

Fixed in #360 and PRs referenced there.

@climbfuji climbfuji mentioned this issue Dec 10, 2019
Merged
@climbfuji climbfuji mentioned this issue Dec 20, 2019
Merged
hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this issue Aug 3, 2022
@climbfuji @dustinswales
@ericaligo-NOAA @DomHeinzeller
Add extended diagnostic output from Thompson MP, includes "Add option…
20883ed 
…al scaling to RRTMGP flux adjustment" (NCAR#319), bug fix in several suite definition files (NCAR#331)

Adds a set of dedicated 3d arrays for extended diagnostic output from Thompon MP, and a logical flag that controls allocating, outputting and resetting these arrays. This work is based on @ericaligo-NOAA 's code changes.

The flag to reset the extended diagnostics from Thompson MP is - for the UFS - currently tied to avg_max_length, which is used to reset maximum hourly fields (the corresponding reset variable is renamed to make its purpose clear).

Include the changes in NCAR#319, "Add optional scaling to RRTMGP flux adjustment".

Important: Fixed bugs in several suite definition files that were missing the call to GFS_radiation_surface:

* suite_FV3_GFS_v15_thompson_mynn_RRTMGP.xml
* suite_FV3_GFS_v16_coupled_noahmp.xml
* suite_FV3_GFS_v16_coupled_nsstNoahmp.xml
* suite_FV3_RRFS_v1alpha.xml

Co-authored-by: Dustin Swales <dustin.swales@noaa.gov>
Co-authored-by: Eric Aligo <eric.aligo@noaa.gov>
Co-authored-by: Dom Heinzeller <dom.heinzeller@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@climbfuji climbfuji

@mdtoy mdtoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@climbfuji @mdtoy