Major updated CSAW deep convective scheme and made the CSAWMG schemes pass RTs for intel and GNU #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feature_reorg_physics
1. adding a heat source from fires. It is icontrolled by a flag and not turned on yet. Needs more testing. 2. Adding output of surface paramteres: leaf area index (LAI), wilting point and soil field capacity.
1. Removed commented lines in fire feedback to RUC LSM. 2. The coordinates of a test point are passed to the RUC LSM subroutines to make debug printing more manageable. 3. Reverted change in the TRANSF subroutine to original version. The non-linear root distribution needs scientific evaluation in the retro runs.
AnningCheng-NOAA
requested review from
andrewgettelman,
mdtoyNOAA,
JongilHan66,
HelinWei-NOAA,
wd20xw,
tanyasmirnova,
barlage,
cenlinhe,
lisa-bengtsson,
yangfanglin,
haiqinli,
mjiacono,
joeolson42,
gthompsnWRF,
AndersJensen-NOAA,
ericaligo-NOAA,
Songyou184,
pjpegion,
SamuelTrahanNOAA and
mzhangw
as code owners
JongilHan66
approved these changes
Feb 13, 2024
|
@AnningCheng-NOAA it says 397 files are changed in this PR? Should it go into something more recent in the ufs-community/ccpp repo and not into NCAR main? |
mdtoyNOAA
approved these changes
Feb 13, 2024
|
Lisa, Those 397 files are likely changed after I checked out the trunk a few weeks ago. I have only modified the cs_conv.F90. There should be numerous conflicts when I merged my branches with the trunk again. |
This was referenced Feb 13, 2024
|
@AnningCheng-NOAA Can you please close this PR and open it in https://github.com/ufs-community/ccpp-physics? |
|
closed PR was put to the wrong repo. |
|
Done. @dustin Swales - NOAA Federal ***@***.***> .
…On Tue, Feb 13, 2024 at 10:34 AM Dustin Swales ***@***.***> wrote:
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> Can you please
close this PR and open it in https://github.com/ufs-community/ccpp-physics
?
(It seems from the commit log that is where you branched your work from)
—
Reply to this email directly, view it on GitHub
<#1063 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIOLLEEXQOZEKWAFUY3YTOBZFAVCNFSM6AAAAABDFQWPTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBRHAYDGMBUHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Major updated CSAW deep convective scheme: considering sigma vertical veriantion and reduction on fluxes instead of tendency etc.
• Regression tests are performed on the new version of CSAW for GNU and intel compilers
Here is a EMail from Don describe the changes:
On Thu, Oct 24, 2019 at 3:01 PM Donald Dazlich - NOAA Affiliate <donald.dazlich@noaa.gov> wrote:
Hi Moorthi, Anning,
Dave and I have been using the GFS version of CS to redo our implementation of AW more completely and consistently. Now, you will find that the fix_form implemetation of the tendencies match up very closely with the traditional form. Also you will notice that it is the fluxes for each cloud type (and the downdraft) that are saved and the reduction is done on the fluxes, not the tendency computed from the flux divergence. Since sigma is a function of height the latter approach is incorrect. I’ve also dimensioned several cloud type variables nctp+1 - the nctp+1 slot has downdraft output. Another addition is the sorting of the lamdas after they are computed for all cloud types, then computing the sigma. This approach is detailed in a manuscript Dave is working on. Also, sigma is not applied to the inputs to the downdraft routine, but to the outputs, which are now mass fluxes not tendencies. The water and thermodynamic budgets remain satisfied now.
I’ve attached my version below. It should be pretty close to your version with regards to the interface so you shouldn’t have to do much work with it.
Regards,
Don