Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master from gsd/develop 2020/11/20 #521

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
e9ca908
Merge pull request #444 from XiaqiongZhou-NOAA/rt_multigases
climbfuji Jul 7, 2020
eab936e
Merge pull request #43 from climbfuji/update_gsd_develop_from_ncar_ma…
DomHeinzeller Jul 8, 2020
a67e879
Merge pull request #4 from NOAA-GSD/gsd/develop
joeolson42 Jul 31, 2020
5d88f7c
Updates and bug fix for MYNN surface layer scheme
joeolson42 Jul 31, 2020
5943288
Changes for flexible number of soil levels.
tanyasmirnova Jul 31, 2020
c341e56
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into HEAD
climbfuji Aug 6, 2020
2735570
Merge pull request #48 from climbfuji/update_gsd_develop_from_ncar_ma…
DomHeinzeller Aug 7, 2020
2235fb5
Add tracer sanitizer
climbfuji Aug 10, 2020
2ac9766
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into tr…
climbfuji Aug 10, 2020
408d078
Bug fix in physics/tracer_sanitizer.F90
climbfuji Aug 11, 2020
f7cd375
Merge pull request #49 from climbfuji/tracer_sanitizer
DomHeinzeller Aug 11, 2020
1c7b52a
- Physics changes made for/during HFIP 2020
hannahcbarnes Aug 13, 2020
ae9e0e2
Merge pull request #50 from hannahcbarnes/HFIP_GFchanges
DomHeinzeller Aug 14, 2020
427ce1e
The first draft of change to mode RUC LSM soil variables initialization
tanyasmirnova Aug 27, 2020
cf4b778
Merge pull request #45 from joeolson42/gsd/develop
DomHeinzeller Aug 28, 2020
5bf8978
A typo is corrected
tanyasmirnova Aug 31, 2020
ff2d8c2
Added index k to printed out names of variables at K soil level.
tanyasmirnova Aug 31, 2020
b411b62
Merge branch 'gsd/develop' of https://github.com/NOAA-GSD/ccpp-physic…
tanyasmirnova Aug 31, 2020
98e378f
Removed the message definition.
tanyasmirnova Sep 1, 2020
361cc15
Syntax errors corrected. Still has an issue in compilation with the use
tanyasmirnova Sep 2, 2020
cc1d5bd
Revert change to rte-rrtmgp submodule pointer
climbfuji Sep 2, 2020
922c05f
physics/sfcsub.F: move message into sfccyc_module
climbfuji Sep 2, 2020
7669914
Merge pull request #1 from climbfuji/gcycle_tanya_update_from_dom_1
tanyasmirnova Sep 2, 2020
45cfe52
1st attempt - Sept. 2
mdtoyNOAA Sep 2, 2020
e19d00d
Increase length of message and update declaration in qcmxmn to avoid …
climbfuji Sep 2, 2020
32ffcfb
Merge pull request #2 from climbfuji/gcycle_tanya_update_from_dom_2
tanyasmirnova Sep 3, 2020
65bc084
Merge pull request #47 from tanyasmirnova/gcycle_ruc
DomHeinzeller Sep 3, 2020
9be03da
Merge branch 'gsd/develop' of https://github.com/NOAA-GSD/ccpp-physic…
tanyasmirnova Sep 3, 2020
317c5cd
physics/sfcsub.F: reduce length of message string for prettier output
climbfuji Sep 3, 2020
e424f0a
Merge pull request #52 from climbfuji/pretty_print_sfcsub
DomHeinzeller Sep 3, 2020
5e8635f
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into HEAD
climbfuji Sep 3, 2020
3a727b9
2nd try -- Sept. 3 -- two scheme test
mdtoyNOAA Sep 4, 2020
8f8dd2e
physics/tracer_sanitizer.meta: add [ccpp-table-properties] section
climbfuji Sep 4, 2020
a05e096
Some progress made but still the model crashes. The changes include:
tanyasmirnova Sep 4, 2020
b917570
Merge branch 'gsd/develop' of https://github.com/NOAA-GSD/ccpp-physic…
tanyasmirnova Sep 4, 2020
f868281
Removed prints and some clean-up.
tanyasmirnova Sep 8, 2020
088fcd4
1st success -- Sept. 9
mdtoyNOAA Sep 9, 2020
3204a42
Bug fix -- Sept. 10
mdtoyNOAA Sep 10, 2020
5ee932a
Sept. 12 bug fix
mdtoyNOAA Sep 13, 2020
278b706
Sept. 14 state
mdtoyNOAA Sep 14, 2020
6e33a57
A syntax error is corrected.
tanyasmirnova Sep 14, 2020
985ca4f
Fractional grid is removed from the RUC soil initialization, since the
tanyasmirnova Sep 15, 2020
f6fd209
Sept. 17 -- debugging
mdtoyNOAA Sep 17, 2020
bd921f5
Bug fixes -- Sept. 18
mdtoyNOAA Sep 18, 2020
44e298a
Removed if(.not. restart) around the call to rucinit.
tanyasmirnova Sep 24, 2020
a96775e
Sept. 28 bug fix
mdtoyNOAA Sep 29, 2020
52c4f54
Remove switch between WRFv3.8.1 and v4+ in module_mp_thompson.F90
climbfuji Oct 1, 2020
27b1d58
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into up…
climbfuji Oct 1, 2020
9fae6f3
Merge pull request #53 from climbfuji/update_gsd_develop_from_master_…
DomHeinzeller Oct 2, 2020
007de08
Merge branch 'gsd/develop' of https://github.com/mdtoy/ccpp-physics i…
mdtoyNOAA Oct 5, 2020
a2728b5
updating tasks 1
mdtoyNOAA Oct 6, 2020
bf9ff71
Merge branch 'gsd/develop' of https://github.com/NOAA-GSD/ccpp-physic…
climbfuji Oct 6, 2020
06b7a07
Updated unified_ugwp.meta to include dependencies.
mdtoyNOAA Oct 7, 2020
94aa9b1
Finalized unified_ugwp.meta dependencies
mdtoyNOAA Oct 7, 2020
d6cd89c
Another unified_ugwp.meta bugfix
mdtoyNOAA Oct 8, 2020
b018da0
Updated unified_ugwp documentation.
mdtoyNOAA Oct 13, 2020
2b41419
If restart=.true. do not set XLAI=0 in the initialization.
tanyasmirnova Oct 13, 2020
762beeb
Corrected syntax error.
tanyasmirnova Oct 13, 2020
ccc9e01
Merge branch 'ruclsm_rucinit_in_lsm_ruc_init' of https://github.com/t…
climbfuji Oct 13, 2020
7d6d8ce
Add capability to print debugging output for all blocks and threads i…
climbfuji Oct 14, 2020
05b9aba
Fix RUC LSM initialization
climbfuji Oct 14, 2020
2caf579
Merge pull request #56 from climbfuji/tanya_ruc_init_updated
DomHeinzeller Oct 15, 2020
748b0bc
Modified code per PR recommendations
mdtoyNOAA Oct 22, 2020
73f06a3
Modified code per G. Firl's PR recommendations
mdtoyNOAA Oct 26, 2020
2cf01d0
cires_vert_orodis_v1.F90 bug fix
mdtoyNOAA Oct 27, 2020
52ec168
Merge branch 'gsd/develop' of https://github.com/NOAA-GSD/ccpp-physic…
mdtoyNOAA Nov 5, 2020
5964c98
Bugfix in cires_ugwp.{F90,meta}: pass missing constants to GWDPS_V0
climbfuji Nov 16, 2020
c3bb4d0
Merge pull request #61 from climbfuji/mike_unified_ugwp_with_dom_mods
DomHeinzeller Nov 17, 2020
74897bb
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into HEAD
climbfuji Nov 18, 2020
af31634
Change horizontal_dimension to horizontal_loop_extent in several new/…
climbfuji Nov 18, 2020
551be29
Bugfix in physics/cires_ugwp_module_v1.F90: remove unnecessary and il…
climbfuji Nov 19, 2020
03942e1
Merge pull request #62 from climbfuji/update_gsd_develop_from_master_…
DomHeinzeller Nov 20, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion physics/GFS_GWD_generic.F90
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ subroutine GFS_GWD_generic_pre_run( &
clx(:,2) = 0.0
clx(:,3) = 0.0
clx(:,4) = 0.0
elseif (nmtvr == 24) then ! GSD_drag_suite
elseif (nmtvr == 24) then ! GSD_drag_suite and unified_ugwp
oc(:) = mntvar(:,2)
oa4(:,1) = mntvar(:,3)
oa4(:,2) = mntvar(:,4)
Expand All @@ -93,6 +93,10 @@ subroutine GFS_GWD_generic_pre_run( &
clx(:,2) = mntvar(:,8)
clx(:,3) = mntvar(:,9)
clx(:,4) = mntvar(:,10)
theta(:) = mntvar(:,11)
gamma(:) = mntvar(:,12)
sigma(:) = mntvar(:,13)
elvmax(:) = mntvar(:,14)
varss(:) = mntvar(:,15)
ocss(:) = mntvar(:,16)
oa4ss(:,1) = mntvar(:,17)
Expand Down
63 changes: 60 additions & 3 deletions physics/GFS_debug.F90
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,37 @@ module GFS_diagtoscreen

contains

subroutine GFS_diagtoscreen_init ()
!> \section arg_table_GFS_diagtoscreen_init Argument Table
!! \htmlinclude GFS_diagtoscreen_init.html
!!
subroutine GFS_diagtoscreen_init (Model, Data, Interstitial, errmsg, errflg)

use GFS_typedefs, only: GFS_control_type, GFS_data_type, &
GFS_interstitial_type

implicit none

!--- interface variables
type(GFS_control_type), intent(in) :: Model
type(GFS_data_type), intent(in) :: Data(:)
type(GFS_interstitial_type), intent(in) :: Interstitial(:)
character(len=*), intent(out) :: errmsg
integer, intent(out) :: errflg

!--- local variables
integer :: i

! Initialize CCPP error handling variables
errmsg = ''
errflg = 0

do i=1,size(Data)
call GFS_diagtoscreen_run (Model, Data(i)%Statein, Data(i)%Stateout, Data(i)%Sfcprop, &
Data(i)%Coupling, Data(i)%Grid, Data(i)%Tbd, Data(i)%Cldprop, &
Data(i)%Radtend, Data(i)%Intdiag, Interstitial(1), &
size(Interstitial), i, errmsg, errflg)
end do

end subroutine GFS_diagtoscreen_init

subroutine GFS_diagtoscreen_finalize ()
Expand All @@ -330,7 +360,6 @@ subroutine GFS_diagtoscreen_run (Model, Statein, Stateout, Sfcprop, Coupling,
#ifdef OPENMP
use omp_lib
#endif
use machine, only: kind_phys
use GFS_typedefs, only: GFS_control_type, GFS_statein_type, &
GFS_stateout_type, GFS_sfcprop_type, &
GFS_coupling_type, GFS_grid_type, &
Expand Down Expand Up @@ -831,7 +860,35 @@ module GFS_interstitialtoscreen

contains

subroutine GFS_interstitialtoscreen_init ()
subroutine GFS_interstitialtoscreen_init (Model, Data, Interstitial, errmsg, errflg)

use GFS_typedefs, only: GFS_control_type, GFS_data_type, &
GFS_interstitial_type

implicit none

!--- interface variables
type(GFS_control_type), intent(in) :: Model
type(GFS_data_type), intent(in) :: Data(:)
type(GFS_interstitial_type), intent(in) :: Interstitial(:)
character(len=*), intent(out) :: errmsg
integer, intent(out) :: errflg

!--- local variables
integer :: i

! Initialize CCPP error handling variables
errmsg = ''
errflg = 0


do i=1,size(Interstitial)
call GFS_interstitialtoscreen_run (Model, Data(1)%Statein, Data(1)%Stateout, Data(1)%Sfcprop, &
Data(1)%Coupling, Data(1)%Grid, Data(1)%Tbd, Data(1)%Cldprop, &
Data(1)%Radtend, Data(1)%Intdiag, Interstitial(i), &
size(Interstitial), -999, errmsg, errflg)
end do

end subroutine GFS_interstitialtoscreen_init

subroutine GFS_interstitialtoscreen_finalize ()
Expand Down
92 changes: 92 additions & 0 deletions physics/GFS_debug.meta
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,52 @@
type = scheme
dependencies = machine.F

########################################################################
[ccpp-arg-table]
name = GFS_diagtoscreen_init
type = scheme
[Model]
standard_name = GFS_control_type_instance
long_name = instance of derived type GFS_control_type in FV3
units = DDT
dimensions = ()
type = GFS_control_type
intent = in
optional = F
[Data]
standard_name = GFS_data_type_instance_all_blocks
long_name = instance of derived type GFS_data_type
units = DDT
dimensions = (ccpp_block_count)
type = GFS_data_type
intent = in
optional = F
[Interstitial]
standard_name = GFS_interstitial_type_instance_all_threads
long_name = instance of derived type GFS_interstitial_type
units = DDT
dimensions = (omp_threads)
type = GFS_interstitial_type
intent = in
optional = F
[errmsg]
standard_name = ccpp_error_message
long_name = error message for error handling in CCPP
units = none
dimensions = ()
type = character
kind = len=*
intent = out
optional = F
[errflg]
standard_name = ccpp_error_flag
long_name = error flag for error handling in CCPP
units = flag
dimensions = ()
type = integer
intent = out
optional = F

########################################################################
[ccpp-arg-table]
name = GFS_diagtoscreen_run
Expand Down Expand Up @@ -135,6 +181,52 @@
type = scheme
dependencies = machine.F

########################################################################
[ccpp-arg-table]
name = GFS_interstitialtoscreen_init
type = scheme
[Model]
standard_name = GFS_control_type_instance
long_name = instance of derived type GFS_control_type in FV3
units = DDT
dimensions = ()
type = GFS_control_type
intent = in
optional = F
[Data]
standard_name = GFS_data_type_instance_all_blocks
long_name = instance of derived type GFS_data_type
units = DDT
dimensions = (ccpp_block_count)
type = GFS_data_type
intent = in
optional = F
[Interstitial]
standard_name = GFS_interstitial_type_instance_all_threads
long_name = instance of derived type GFS_interstitial_type
units = DDT
dimensions = (omp_threads)
type = GFS_interstitial_type
intent = in
optional = F
[errmsg]
standard_name = ccpp_error_message
long_name = error message for error handling in CCPP
units = none
dimensions = ()
type = character
kind = len=*
intent = out
optional = F
[errflg]
standard_name = ccpp_error_flag
long_name = error flag for error handling in CCPP
units = flag
dimensions = ()
type = integer
intent = out
optional = F

########################################################################
[ccpp-arg-table]
name = GFS_interstitialtoscreen_run
Expand Down
Loading