Wrapper for #812 #819
Merged
Wrapper for #812 #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
equation that accounts for varying air density.
This was referenced Dec 22, 2021
grantfirl
requested review from
climbfuji,
mkavulich and
SamuelTrahanNOAA
as code owners
climbfuji
reviewed
Dec 22, 2021
There was a problem hiding this comment.
As far as I understand the code changes, they do what the description says: Take into account that air density changes with altitude. One could consider defining a variable 1/grav to avoid the repeated divisions? (But maybe the compiler does that automatically.)
climbfuji
approved these changes
Dec 22, 2021
Merged
16 tasks
SamuelTrahanNOAA
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ALL CREDIT TO @rmontuoro FOR THIS PR. THIS WRAPPER IS ONLY TO UPDATE TO LATEST MAIN FOR TESTING/MERGING PURPOSES. All description below is from #812:
This PR implements a vertically-integrated formula to compute tracer column mass and ensure mass conservation for all tracers except TKE. The formula properly computes the tracer mass at each layer dm(z) taking into account that the air density rho(z) changes with altitude (z):
where q(z) is the tracer mixing ratio.
This PR will change the baseline for all regression tests using Scale-Aware Mass-Flux (SAMF) shallow or deep convective schemes, as well as the Scale-aware TKE-based Moist Eddy-Diffusivity Mass-Flux (SATMEDMF) PBL scheme.
Resolves issue #811