Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SCM to the latest ccpp-physics/framework main #295

Merged
merged 6 commits into from
Jan 26, 2022

Conversation

grantfirl
Copy link
Collaborator

This pull request catches the SCM up to the latest ccpp-physics main as of Jan 25, 2022 and implements changes to be consistent with the fv3atm pull requests listed below.

Associated PRs:
ccpp-physics

ccpp-framework

fv3atm

Testing

  • ran multi_run_scm.py, plotted and visually checked results for TWPICE case
  • ran SCM RTs: all tests completed successfully with different results for the GSD_v1, RRFS_v1alpha, and GFS_v16 suites due to changes (at least) to the Thompson MP (GSD_v1, RRFS) and satmedmfvdifq PBL (GFS_v16) schemes.

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One type in GFS_typedefs.F90, which is probably also in FV3atm and should be corrected at some point.

scm/src/GFS_typedefs.F90 Outdated Show resolved Hide resolved
Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com>
@grantfirl
Copy link
Collaborator Author

@mkavulich This is an example of a SCM pull request that "catches up" with the other repos (ccpp-physics, ccpp-framework, and fv3atm). All changes in here have been reviewed somewhere else, so this is typically an easy review. Would you like to take a look before I merge?

@grantfirl grantfirl merged commit 04b5bcb into NCAR:main Jan 26, 2022
mkavulich pushed a commit that referenced this pull request May 12, 2022
Update SCM to the latest ccpp-physics/framework main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants