Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parser #119

Merged
merged 6 commits into from
Jul 19, 2023
Merged

Update parser #119

merged 6 commits into from
Jul 19, 2023

Conversation

boulderdaze
Copy link
Collaborator

@boulderdaze boulderdaze commented Jul 14, 2023

Completed

  • Added a function to parse TroeRateConstants
  • Updated the function to configure species to store additional key-value from molecular weight [kg mol-1]
  • Added unit tests to parse a subset of MZ326 data that includes troe reactions and species that have molecular weight [kg mol-1]
  • Added constants.hpp to store scientific constants

Comments: Becausemap_params branch is still under review, I think it is hard to tell the changes made specific with the new data. I will leave this as a draft until the previous branch is merged into main.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Patch coverage: 91.35% and project coverage change: -0.18 ⚠️

Comparison is base (4b1e6f7) 95.10% compared to head (0a05032) 94.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   95.10%   94.93%   -0.18%     
==========================================
  Files          23       23              
  Lines        1818     1875      +57     
==========================================
+ Hits         1729     1780      +51     
- Misses         89       95       +6     
Impacted Files Coverage Δ
include/micm/configure/solver_config.hpp 86.22% <91.35%> (-0.08%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@boulderdaze boulderdaze marked this pull request as ready for review July 18, 2023 20:44
@boulderdaze boulderdaze changed the title Draft:Update parser Update parser Jul 18, 2023
@mattldawson mattldawson merged commit 67d97f7 into main Jul 19, 2023
13 checks passed
@mattldawson mattldawson deleted the update_parser branch July 19, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants