Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take cyclicity into account when assessing bounds for contiguousness #75

Closed
davidhassell opened this issue May 15, 2020 · 1 comment · Fixed by #72
Closed

Take cyclicity into account when assessing bounds for contiguousness #75

davidhassell opened this issue May 15, 2020 · 1 comment · Fixed by #72
Assignees
@davidhassell
Labels
enhancement New feature or request

Comments

@davidhassell
Copy link
Collaborator

davidhassell commented May 15, 2020 •
edited

Currently in cf.Bounds.contiguous (cf 3.4.0) longitude bounds values of -180 and 180 and not considered to be the same. The periodicity of the physical quantity (e,g, longitudes) should taken into account.
@davidhassell davidhassell added the enhancement New feature or request label May 15, 2020
@davidhassell davidhassell changed the title Take cyclicity into account when assessing cbounds for contiguousness Take cyclicity into account when assessing bounds for contiguousness May 18, 2020
@davidhassell davidhassell self-assigned this May 18, 2020
@davidhassell davidhassell mentioned this issue May 18, 2020
Merged
@davidhassell
Copy link
Collaborator Author

Fix will go into 3.5.0

davidhassell added a commit that referenced this issue Jun 3, 2020
@davidhassell
Merge pull request #72 from davidhassell/halo
409d873 
Halo method (fixes #71, #73, #75, #81)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidhassell davidhassell

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Halo method (fixes #71, #73, #75, #81) davidhassell/cf-python
1 participant
@davidhassell