-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dask: cf.Field.regrids
and cf.Field.regridc
#438
dask: cf.Field.regrids
and cf.Field.regridc
#438
Conversation
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Addressing the general minor comments:
We'll open a new PR for this.
Sorted: 2ca3e2c
As discussed, Ankit and I don't :) We'll put it down to rogue versions and ignore.
Sorted: ee57d6e
Annoying, but we'll ignore for now. It's possible that when merged into lama-to-dask they'll get fixed, as this quite an old PR. Maybe! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback all addressed very well. Lovely, please merge.
A very large thank you to Sadie for tackling the review of this rather large PR. Nice job. |
(I've since realised my main initial review comment got mangled, but understood and discussed offline anyway.) |
I'm finished. In many ways.
Hopefully self explanatory ... might be easiest to start at
cf.Field.regrid[sc]
and work backwards from there.I'll draw a bit of UML-like to outline the structure. Watch this space.
You need to run
python create_test_files.py
before testing for the first time.Thanks!