Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow cell area calculation to ignore cell measure constructs #710

Merged
merged 14 commits into from
Feb 13, 2024
Merged

Allow cell area calculation to ignore cell measure constructs #710

merged 14 commits into from
Feb 13, 2024

Conversation

davidhassell
Copy link
Collaborator

FIxes #709

@davidhassell davidhassell added this to the Next release milestone Feb 7, 2024
sadielbartholomew
sadielbartholomew approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds the feature promised. Nice implementation. Minor comments raised, but overall this is all good, so please merge once those have been considered and included if you agree with my points. Thanks.

cf/field.py Outdated Show resolved Hide resolved
cf/field.py Outdated Show resolved Hide resolved
cf/field.py Outdated Show resolved Hide resolved
cf/field.py Outdated Show resolved Hide resolved
cf/field.py Outdated Show resolved Hide resolved
cf/field.py Outdated Show resolved Hide resolved
cf/test/test_weights.py Outdated Show resolved Hide resolved
davidhassell and others added 9 commits February 13, 2024 10:54
@davidhassell @sadielbartholomew
Docstring clarity
8a2947e 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Docstring clarity
10d2b6c 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
b09adab 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Typo
bc50bd9 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Remove unnecessary import
5ce5894 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Docstring clarity
46edd7f 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Parameter checking
3a8eeae 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell
remove blank line
b3d167e
@davidhassell
Merge branch 'main' into cell-measures
7134fcf
@davidhassell davidhassell merged commit eb779fb into NCAS-CMS:main Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.16.1
Development

Successfully merging this pull request may close these issues.

Allow cell area calculation to ignore cell measure constructs
2 participants
@davidhassell @sadielbartholomew