-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New method pad_missing to support aggregation of DSGs #718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation and tests are excellent. As well as for the VISION context this was made with in mind, I think these methods could be really useful.
Great stuff, please merge when ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming a re-approval and that I have sanity checked the update resulting from #718. (I also went in to solve one trivial merge conflict whilst I was here so it is all ready to go.) Perfect, please merge.
Hi Sadie - I've added a new |
Sure, that sounds useful. OK, I'll do a final review inclusive of the new commit. One moment... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New commit is all good (and a useful addition to the new method). Please merge (at last!).
Fixes #717