Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For DSGs, don't attempt to aggregate non-feature axes #730

Merged
merged 6 commits into from
Mar 1, 2024

Conversation

davidhassell
Copy link
Collaborator

Fixes #723, along with #724

Additional logic that didn't make it into #724

@davidhassell davidhassell added enhancement New feature or request aggregation Rerlating to metadata-based field and domain aggregation labels Feb 29, 2024
@davidhassell davidhassell added this to the 3.16.1 milestone Feb 29, 2024
@sadielbartholomew sadielbartholomew changed the title For DSGs, don't attempt to aggreaget non-feature axes For DSGs, don't attempt to aggregate non-feature axes Mar 1, 2024
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, but all good so please merge once you've considered it (not a blocker by any means).

cf/aggregate.py Outdated Show resolved Hide resolved
@davidhassell davidhassell merged commit 230d964 into NCAS-CMS:main Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aggregation Rerlating to metadata-based field and domain aggregation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow DSG tractories with identical trajectory_id values to be aggregated.
2 participants