Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognise LBPROC 131072 when reading UM files #738

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Recognise LBPROC 131072 when reading UM files #738

merged 1 commit into from
Mar 14, 2024

Conversation

davidhassell
Copy link
Collaborator

Fixes #737

@davidhassell davidhassell added the bug Something isn't working label Mar 13, 2024
@davidhassell davidhassell added this to the Next release milestone Mar 13, 2024
sadielbartholomew
sadielbartholomew approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good as far as I can tell. I'd ask for a corresponding test, but I suspect this one might be difficult to test on, so please merge if happy.

@davidhassell
Copy link
Collaborator Author

I suspect this one might be difficult to test on

I think so - It works in the only use case known to exist, so I'm happy with that :)

@davidhassell davidhassell merged commit a90a26f into NCAS-CMS:main Mar 14, 2024
2 of 4 checks passed
@davidhassell davidhassell deleted the lbproc-131072 branch March 14, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.16.2
Development

Successfully merging this pull request may close these issues.

Recognise LBPROC 131072 (Mean over an ensemble of parallel runs) when reading UM files
2 participants
@davidhassell @sadielbartholomew