Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review ADCAD 1.0.0 release #9

Open
amoeba opened this issue Dec 17, 2021 · 5 comments
Open

Review ADCAD 1.0.0 release #9

amoeba opened this issue Dec 17, 2021 · 5 comments
Assignees

Comments

@amoeba
Copy link
Contributor

amoeba commented Dec 17, 2021

@mbjones asked for a quick check before #7 and #8

@amoeba amoeba self-assigned this Dec 17, 2021
@amoeba
Copy link
Contributor Author

amoeba commented Dec 17, 2021

Hey @mbjones I found one thing I think we should address before broader distribution: The PLOS alignment uses http://localhost URIs everywhere:

@prefix plos: <http://localhost/plosthes.2017-1#> .
...
skos:exactMatch <http://localhost/plosthes.2017-1#2668>, wikidata:Q23498 .

And the PLOSTHES.ttl file has the same thing:

<http://localhost/plosthes.2017-1>
    a :NamedIndividual, skos:ConceptScheme ;
    skos:hasTopConcept <http://localhost/plosthes.2017-1#10580>, <http://localhost/plosthes.2017-1#10670>, <http://localhost/plosthes.2017-1#1969>, <http://localhost/plosthes.2017-1#1990>, <http://localhost/plosthes.2017-1#2884>, <http://localhost/plosthes.2017-1#3625>, <http://localhost/plosthes.2017-1#3917>, <http://localhost/plosthes.2017-1#4019>, <http://localhost/plosthes.2017-1#7094>, <http://localhost/plosthes.2017-1#8400>, <http://localhost/plosthes.2017-1#8539> .

This looks like an upstream issue. Are we okay with it?

@mbjones
Copy link
Member

mbjones commented Dec 17, 2021

Yes, I looked into it, and that is what PLOSTHES uses in its main source. It is an odd pattern, but technically it only needs to be a unique name. They, of course, will not resolve. But that is how PLOS named their term URIs. So I decided to go with it.

@mpsaloha
Copy link

mpsaloha commented Dec 17, 2021 via email

@mbjones
Copy link
Member

mbjones commented Dec 17, 2021

We're not "using" the PLOS terms at all, in the sense that we are not defining them. Instead, we are defining an ADCAD term, and then using the PLOS uri as the object of a skos:exactMatch. Somewhere in our ontology I want to link our terms to the exact URI used by PLOS. For example, the PLOSTHES class for "Social Sciences" has the term URI http://localhost/plosthes.2017-1#8539 and can be viewed here: https://bioportal.bioontology.org/ontologies/PLOSTHES/?p=classes&conceptid=http%3A%2F%2Flocalhost%2Fplosthes.2017-1%238539

The corresponding triples I have in ADCAD are:

odo:ADCAD_00004
    a owl:Class ;
    rdfs:label "Social Science" ;
    rdfs:subClassOf odo:ADCAD_00000 ;
    skos:exactMatch <http://localhost/plosthes.2017-1#8539>, wikidata:Q34749 .

@amoeba
Copy link
Contributor Author

amoeba commented Dec 18, 2021

Thanks @mbjones, makes sense to me. Everything looks good to me, then. If/when the PLOS terms get new URIs, we can update our linkage here. I'll subscribe to that issue.

I'm going to leave this ticket open just so the conversation above can continue. Since 1.0.0 is reviewed and tagged, I'm going to push this out since any changes resulting from the discussion here would go in a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants