Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geohash boxes float above the earth's surface in Cesium #2070

Closed
robyngit opened this issue Oct 14, 2022 · 1 comment · Fixed by #2127
Closed

geohash boxes float above the earth's surface in Cesium #2070

robyngit opened this issue Oct 14, 2022 · 1 comment · Fixed by #2127
Assignees
@robyngit
Labels
bug cesium
Milestone
2.25.0

Comments

@robyngit
Copy link
Member

We need to fix position of geohash boxes. Currently, they are placed above the surface of the Earth, and a user is able to zoom below them until they disappear or otherwise appear to float above the ground.

In the screenshot below, the blue is the geohash, not the sky:
Screen Shot 2022-10-14 at 16 45 48
@robyngit robyngit self-assigned this Oct 14, 2022
@robyngit
Copy link
Member Author

robyngit commented Dec 2, 2022 •
edited

Note: We can clamp entities to the ground like this, but then outlines are not supported. If there are no outlines around the geohashes, it will be difficult / impossible to tell side-by-side geohashes apart. See also: example with CZML

@robyngit robyngit mentioned this issue Dec 2, 2022
Closed
robyngit added a commit that referenced this issue Jan 12, 2023
@robyngit
Use the CesiumVectorData model for Geohashes
2b9765b 
- Make CesiumGeohash an extension of CesiumVectorData instead of MapAsset
- Add Geohash specific properties to the CesiumGeohash model (e.g. precisionAltMap, bounds, level, geohashes, etc.)
- Add a ToJSON function to the CesiumGeohash model that converts geohash & search result information to a JSON object
- Create listeners for updating Geohashes when the bounds & altitude change
- Add ability to update the data source in the CesiumVectorData model
- Always set ClampToGround to true for geohashes

Relates to #1720, #2063, #2070, #2076
robyngit added a commit that referenced this issue Feb 3, 2023
@robyngit
Use the CesiumVectorData model for Geohashes
0800f2e 
- Make CesiumGeohash an extension of CesiumVectorData instead of MapAsset
- Add Geohash specific properties to the CesiumGeohash model (e.g. precisionAltMap, bounds, level, geohashes, etc.)
- Add a ToJSON function to the CesiumGeohash model that converts geohash & search result information to a JSON object
- Create listeners for updating Geohashes when the bounds & altitude change
- Add ability to update the data source in the CesiumVectorData model
- Always set ClampToGround to true for geohashes

Relates to #1720, #2063, #2070, #2076
@robyngit robyngit added this to the 2.24.0 milestone Mar 15, 2023
@robyngit robyngit linked a pull request Apr 20, 2023 that will close this issue
New CatalogSearchView with configurable filters & Cesium map #2127
Merged
@robyngit robyngit modified the milestones: 2.24.0, 2.25.0 May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robyngit robyngit

Labels
bug cesium
Projects
None yet
Milestone
2.25.0
Development

Successfully merging a pull request may close this issue.

New CatalogSearchView with configurable filters & Cesium map NCEAS/metacatui
1 participant
@robyngit