Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit drawing GeoHashes to the view extent in the Cesium map #2076

Closed
robyngit opened this issue Dec 2, 2022 · 1 comment · Fixed by #2127
Closed

Limit drawing GeoHashes to the view extent in the Cesium map #2076

robyngit opened this issue Dec 2, 2022 · 1 comment · Fixed by #2127
Assignees
@robyngit
Labels
ADC CI-16 Geospatial search improvements (ADC deliverable) arctic data center bug cesium
Milestone
2.25.0

Comments

@robyngit
Copy link
Member

robyngit commented Dec 2, 2022

In the beta release of Cesium in the data catalog, we "draw" GeoHashes on the map using Cesium's Entity API. It appears that we are not checking which range of the surface of the Earth is visible, and as a result, GeoHashes are rendered for the entire globe. When there are many of datasets and a user is zoomed in, this results in so many GeoHash Entities being drawn that the browser tab freezes. We already enabled the Cesium View to measure the visible area of map and save it to the map model each time the camera position changes, see #1939. We should use this currentViewExtent map attribute to only draw GeoHashes that are in view.
@robyngit robyngit mentioned this issue Dec 2, 2022
Closed
robyngit added a commit that referenced this issue Jan 12, 2023
@robyngit
Use the CesiumVectorData model for Geohashes
2b9765b 
- Make CesiumGeohash an extension of CesiumVectorData instead of MapAsset
- Add Geohash specific properties to the CesiumGeohash model (e.g. precisionAltMap, bounds, level, geohashes, etc.)
- Add a ToJSON function to the CesiumGeohash model that converts geohash & search result information to a JSON object
- Create listeners for updating Geohashes when the bounds & altitude change
- Add ability to update the data source in the CesiumVectorData model
- Always set ClampToGround to true for geohashes

Relates to #1720, #2063, #2070, #2076
robyngit added a commit that referenced this issue Jan 18, 2023
@robyngit
Render geohashes at p. meridian & all precisions
4e07636 
- add height to the map model's currentViewExtent property on camera change (use height to get geohash precision)
- tweak altitude-geohash precision map
- fix issue where no geohashes were rendered when the view extent crossed the prime meridian

Relates to #1720, #2076
@robyngit robyngit self-assigned this Jan 24, 2023
robyngit added a commit that referenced this issue Feb 3, 2023
@robyngit
Use the CesiumVectorData model for Geohashes
0800f2e 
- Make CesiumGeohash an extension of CesiumVectorData instead of MapAsset
- Add Geohash specific properties to the CesiumGeohash model (e.g. precisionAltMap, bounds, level, geohashes, etc.)
- Add a ToJSON function to the CesiumGeohash model that converts geohash & search result information to a JSON object
- Create listeners for updating Geohashes when the bounds & altitude change
- Add ability to update the data source in the CesiumVectorData model
- Always set ClampToGround to true for geohashes

Relates to #1720, #2063, #2070, #2076
robyngit added a commit that referenced this issue Feb 3, 2023
@robyngit
Render geohashes at p. meridian & all precisions
bab25a4 
- add height to the map model's currentViewExtent property on camera change (use height to get geohash precision)
- tweak altitude-geohash precision map
- fix issue where no geohashes were rendered when the view extent crossed the prime meridian

Relates to #1720, #2076
@robyngit robyngit added this to the 2.24.0 milestone Mar 15, 2023
@robyngit
Copy link
Member Author

robyngit commented Apr 7, 2023

Done in the feature-#1720-cesium-data-catalog branch

@robyngit robyngit linked a pull request Apr 20, 2023 that will close this issue
New CatalogSearchView with configurable filters & Cesium map #2127
Merged
@robyngit robyngit modified the milestones: 2.24.0, 2.25.0 May 15, 2023
@robyngit robyngit added the ADC CI-16 Geospatial search improvements (ADC deliverable) label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robyngit robyngit

Labels
ADC CI-16 Geospatial search improvements (ADC deliverable) arctic data center bug cesium
Projects
Arctic Data Center Management Plan Deliverables
Status: Done
Milestone
2.25.0
Development

Successfully merging a pull request may close this issue.

New CatalogSearchView with configurable filters & Cesium map NCEAS/metacatui
1 participant
@robyngit