-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unit Tests #1
Conversation
These unit tests look good to me! However, it worries me that some of the GitHub Actions (GHAs) failed on your last push. I did some digging in the GHA details and found this warning/error. Seems like for some reason the Doesn't seem like our fault though so my push just now was to check whether commenting out just that bit would cause the GHAs to succeed. If they do work, I'm happy to green light merging this PR even without that unit test but I'd also support you if you felt like figuring out why it works locally but not on GitHub. |
…evelopment version GHA R-CMD check
Thanks for looking these over, Nick!! The checks were successful locally so I was a bit stumped that the GHAs failed 🤕 getting all these package version to work together in all scenarios can be tricky.. I want to merge the PR but it seems that another GHA is failing due to the example for |
In order to pass the GHA checks, I removed Then to refine Everything seem to work locally and the GHA checks all pass so it should be good to go now! I will merge the PR 🎉 |
This is just the scaffolding of the unit testing architecture. Opening this PR now just so this task doesn't slip off of either of our radars. See GitHub Enterprise issue #265 for more details