Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Epic 1963: Address Java checkstyle warnings #1521

Open
gjvoosten opened this issue Mar 29, 2019 · 2 comments
Open

Epic 1963: Address Java checkstyle warnings #1521

gjvoosten opened this issue Mar 29, 2019 · 2 comments
Labels
debt

Comments

@gjvoosten
Copy link
Collaborator

./gradlew checkstyleMain checkstyleTest reports some warnings; these should be addressed
@gjvoosten gjvoosten added the debt label Mar 29, 2019
@gjvoosten gjvoosten mentioned this issue Apr 16, 2019
Merged
gjvoosten added a commit that referenced this issue Jul 9, 2019
@gjvoosten
#1521: Override some Google rules for our codebase
d8c26f4
gjvoosten added a commit that referenced this issue Jul 9, 2019
@gjvoosten
#1521: Fix some Checkstyle warnings
66a17de
@maradragan maradragan mentioned this issue Jul 9, 2019
Closed
4 tasks
@maradragan maradragan changed the title Address Java checkstyle warnings Epic 1963: Address Java checkstyle warnings Jul 9, 2019
VassilIordanov added a commit that referenced this issue Jul 10, 2019
@VassilIordanov
Merge pull request #1962 from NCI-Agency/GH-1521-checkstyle
aebf517 
Address some Checkstyle warnings
@gjvoosten gjvoosten mentioned this issue Dec 12, 2019
Merged
@jose-west jose-west mentioned this issue Feb 27, 2020
Closed
@VassilIordanov
Copy link
Contributor

@gjvoosten does this need closing?

@gjvoosten
Copy link
Collaborator Author

There's still quite a few Checkstyle warnings that could/should be fixed. For those that we don't want to fix, we should relax the rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gjvoosten @VassilIordanov