Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all-day report indicators throughout UI #3024

Open
ysf-simsoft opened this issue May 15, 2020 · 0 comments · May be fixed by #3071
Open

Add all-day report indicators throughout UI #3024

ysf-simsoft opened this issue May 15, 2020 · 0 comments · May be fixed by #3071
Labels
D2 [ ~4h ] Difficulty - medium enhancement
Projects
Milestone

Comments

@ysf-simsoft
Copy link
Contributor

Currently, when creating a report if duration field is left blank, that report is considered to be an all-day event. However this consideration is vague because of two reasons:

  1. Entering a time (hour:minute) for an all-day event creates ambiguity.
  2. Throughout the UI there is no indication of whether an event is an all-day event or not (except ReportCalendar week, day, list-day views).

Prospective solution would be;

  1. When creating/editing a report, either;
    1. Allow user to explicitly choose whether this report is an all-day event or not.
      • Add a checkbox under the calendar with label "Create all-day event".
      • If checkbox is checked;
        1. Set duration to null and hide/disable the duration field.
        2. Disallow time selection in calendar.
        3. Automatically set time to 00:00 on selected engagementDate.
    2. Keep current behavior. If duration is set to 0 (zero) or left blank, consider it as an all-day event.
      • Add a hint/message under the duration field such as; "If duration is blank or 0 an all-day event will be created".
      • Allow user to select time regardless of duration value.
  2. When displaying reports throughout the UI;
    1. If event is an all-day event; don't display time and add an indicator next to engagementDate such as; 05-05-2020 (all day)
    2. If event is not an all-day event; display start and end times along with engagementDate such as; 05-05-2020 01:00-03:00

Currently, if duration is set to null, in ReportCalendar component, events are displayed in all days section on week, day, list-day views.

@ysf-simsoft ysf-simsoft added this to Triage in ANET May 18, 2020
@ysf-simsoft ysf-simsoft added the D2 [ ~4h ] Difficulty - medium label May 20, 2020
@VassilIordanov VassilIordanov added this to the 2020 June milestone Jun 1, 2020
ysf-simsoft added a commit that referenced this issue Jun 16, 2020
Move those fields to a dedicated component in order to implement
all-day related features in isolation.
ysf-simsoft added a commit that referenced this issue Jun 16, 2020
Add allDay and fullWidth props to DatePicker in order to provide needed
functionality for all-day events.
ysf-simsoft added a commit that referenced this issue Jun 16, 2020
Move those fields to a dedicated component in order to implement
all-day related features in isolation.
ysf-simsoft added a commit that referenced this issue Jun 16, 2020
Add allDay and fullWidth props to DatePicker in order to provide needed
functionality for all-day events.
ysf-simsoft added a commit that referenced this issue Jun 17, 2020
Move those fields to a dedicated component in order to implement
all-day related features in isolation.
ysf-simsoft added a commit that referenced this issue Jun 17, 2020
Add allDay and fullWidth props to DatePicker in order to provide needed
functionality for all-day events.
@ysf-simsoft ysf-simsoft linked a pull request Jun 17, 2020 that will close this issue
14 tasks
ysf-simsoft added a commit that referenced this issue Jun 22, 2020
Move those fields to a dedicated component in order to implement
all-day related features in isolation.
ysf-simsoft added a commit that referenced this issue Jun 22, 2020
Add allDay and fullWidth props to DatePicker in order to provide needed
functionality for all-day events.
ysf-simsoft added a commit that referenced this issue Jul 24, 2020
Move those fields to a dedicated component in order to implement
all-day related features in isolation.
ysf-simsoft added a commit that referenced this issue Jul 24, 2020
Add allDay and fullWidth props to DatePicker in order to provide needed
functionality for all-day events.
ysf-simsoft added a commit that referenced this issue Aug 22, 2020
Move those fields to a dedicated component in order to implement
all-day related features in isolation.
ysf-simsoft added a commit that referenced this issue Aug 22, 2020
Add allDay and fullWidth props to DatePicker in order to provide needed
functionality for all-day events.
cemalettin-work pushed a commit that referenced this issue Oct 12, 2020
Move those fields to a dedicated component in order to implement
all-day related features in isolation.
cemalettin-work pushed a commit that referenced this issue Oct 12, 2020
Add allDay and fullWidth props to DatePicker in order to provide needed
functionality for all-day events.
@cemalettin-work cemalettin-work self-assigned this Oct 16, 2020
cemalettin-work pushed a commit that referenced this issue Nov 19, 2020
Move those fields to a dedicated component in order to implement
all-day related features in isolation.
cemalettin-work pushed a commit that referenced this issue Nov 19, 2020
Add allDay and fullWidth props to DatePicker in order to provide needed
functionality for all-day events.
cemalettin-work added a commit that referenced this issue Dec 14, 2020
Also fine tune column sizes on engagement planning part
cemalettin-work added a commit that referenced this issue Dec 14, 2020
Also fine tune column sizes on engagement planning part
cemalettin-work pushed a commit that referenced this issue Dec 22, 2020
Move those fields to a dedicated component in order to implement
all-day related features in isolation.
cemalettin-work pushed a commit that referenced this issue Dec 22, 2020
Add allDay and fullWidth props to DatePicker in order to provide needed
functionality for all-day events.
cemalettin-work added a commit that referenced this issue Dec 22, 2020
Also fine tune column sizes on engagement planning part
cemalettin-work pushed a commit that referenced this issue Dec 28, 2020
Move those fields to a dedicated component in order to implement
all-day related features in isolation.
cemalettin-work pushed a commit that referenced this issue Dec 28, 2020
Add allDay and fullWidth props to DatePicker in order to provide needed
functionality for all-day events.
cemalettin-work added a commit that referenced this issue Dec 28, 2020
Also fine tune column sizes on engagement planning part
@gjvoosten gjvoosten moved this from Doing to Ready for review in ANET Feb 24, 2021
@midmarch midmarch moved this from Ready for review to On Hold / stuck in ANET Mar 8, 2021
@midmarch midmarch moved this from On Hold / stuck to Confirmed in ANET Oct 6, 2021
@midmarch midmarch moved this from Confirmed to Planned for current/next sprint in ANET Oct 6, 2021
@gjvoosten gjvoosten moved this from Planned for current/next sprint to Ready for review in ANET Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D2 [ ~4h ] Difficulty - medium enhancement
Projects
ANET
  
Ready for review
Development

Successfully merging a pull request may close this issue.

4 participants