Add all day report indicators #3071
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysf-simsoft
force-pushed
the
GH-3024-add-all-day-report-indicators
branch
from
cfa3e26
to
2d89fb8
Compare
ysf-simsoft
force-pushed
the
GH-3024-add-all-day-report-indicators
branch
from
2d89fb8
to
b9eed26
Compare
ysf-simsoft
force-pushed
the
GH-3024-add-all-day-report-indicators
branch
from
b9eed26
to
b285599
Compare
cemalettin-work
force-pushed
the
GH-3024-add-all-day-report-indicators
branch
from
b285599
to
673b781
Compare
cemalettin-work
changed the title
|
Currently, the ui looks like this for different places where reports are displayed. |
cemalettin-work
force-pushed
the
GH-3024-add-all-day-report-indicators
branch
from
df1d0d1
to
a3f4347
Compare
gjvoosten
force-pushed
the
GH-3024-add-all-day-report-indicators
branch
from
a3f4347
to
fc1d60e
Compare
gjvoosten
requested changes
Nov 25, 2020
client/tests/webdriver/specs/createReportWithPlanningConflict.spec.js
Outdated
Show resolved
Hide resolved
cemalettin-work
force-pushed
the
GH-3024-add-all-day-report-indicators
branch
3 times, most recently
from
5eea151
to
b117e54
Compare
cemalettin-work
force-pushed
the
GH-3024-add-all-day-report-indicators
branch
4 times, most recently
from
0ec9c17
to
35b9e9d
Compare
gjvoosten
requested changes
Nov 26, 2020
gjvoosten
reviewed
Nov 26, 2020
gjvoosten
reviewed
Nov 26, 2020
client/tests/webdriver/specs/createReportWithPlanningConflict.spec.js
Outdated
Show resolved
Hide resolved
cemalettin-work
force-pushed
the
GH-3024-add-all-day-report-indicators
branch
from
35b9e9d
to
2c8a389
Compare
cemalettin-work
force-pushed
the
GH-3024-add-all-day-report-indicators
branch
from
2c8a389
to
854c338
Compare
cemalettin-work
force-pushed
the
GH-3024-add-all-day-report-indicators
branch
from
854c338
to
418d296
Compare
Move those fields to a dedicated component in order to implement all-day related features in isolation.
Add allDay and fullWidth props to DatePicker in order to provide needed functionality for all-day events.
Also fine tune column sizes on engagement planning part
cemalettin-work
force-pushed
the
GH-3024-add-all-day-report-indicators
branch
from
418d296
to
1a85940
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An "All day" checkbox is added to report form. Previously, reports are considered to be all-day events when duration field is left empty (specifically when duration was
null). This behavior is preserved while giving an option (by checking all-day checkbox) to the user for explicitly setting the report as an all-day event.When creating a new report all-day checkbox is initially checked and duration field is disabled. If user enters a time other than 00:00 in date picker, checkbox is automatically cleared and duration field is automatically enabled. At this point, entering a duration is required because time is entered (even though duration is optional initially).
If all-day checkbox gets checked after user enters time and duration, time gets reset to 00:00 (start of day) and duration gets reset to
nulland duration field gets disabled.Release notes
Closes #3024
User changes
Super User changes
Admin changes
System admin changes
none
anet.yml needs change
db needs migration
documentation has changed
graphql schema has changed
Checklist
repo#issue: Titletitle format and these 7 rules