Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to generate a PDF of combined daily engagement reports #3941

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

asafkaganbezgin
Copy link
Contributor

@asafkaganbezgin asafkaganbezgin commented Dec 15, 2021

Users go to archive center and specify a time frame and then press download button. Reports published between the specified time frame are printed inside a PDF generated at server side. All of the reports are put inside one PDF file; reports inside of the file are separated by page break.

Things that are missing on server side:

  • It should be determined which report information should be shown (not all report fields are currently displayed).
  • Some fields are shown in Object format inside of report. They should show proper key value pairs inside report.
  • CustomSensitive & ReportSensitive fields are not meant to be shown inside PDFs. However, if client side request them, they could be shown inside reports. There is no mechanism on server side to block that.
  • Server side tests should be written.
  • There are TODOs waiting to be handled.

Things that are missing on client side:

  • Archive Center page should be prettified by staying consistent with the rest of the UI, showing proper information to the user.
  • There should be start and end date fields for user to specify the time range. The current download button requests all reports in the system.

Closes AB#263

User changes

  • It is possible to export reports published between a specified time frame.

Super User changes

  • None

Admin changes

  • None

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@asafkaganbezgin asafkaganbezgin self-assigned this Dec 15, 2021
@lgtm-com
Copy link

lgtm-com bot commented Dec 15, 2021

This pull request introduces 1 alert when merging 2bce40f into c3cd9bc - view on LGTM.com

new alerts:

  • 1 for Useless parameter

@anilsonmez-simsoft anilsonmez-simsoft force-pushed the AB-263-Ability-to-generate-a-PDF-of-combined-daily-engagement-reports branch from 2bce40f to e96a9c3 Compare February 25, 2022 06:57
@anilsonmez-simsoft anilsonmez-simsoft force-pushed the AB-263-Ability-to-generate-a-PDF-of-combined-daily-engagement-reports branch from e96a9c3 to d6d2cba Compare February 25, 2022 06:58
@lgtm-com
Copy link

lgtm-com bot commented Feb 25, 2022

This pull request introduces 1 alert when merging d6d2cba into 56825af - view on LGTM.com

new alerts:

  • 1 for Useless parameter

@anilsonmez-simsoft anilsonmez-simsoft force-pushed the AB-263-Ability-to-generate-a-PDF-of-combined-daily-engagement-reports branch from d6d2cba to f4e1666 Compare February 25, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants