-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(versioning): Add support for auto data versioning #355
Conversation
psql -U postgres -c "create database automated_test with owner test;" | ||
psql -U postgres -c "create database dev_models with owner test;" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing new line at end-of-line
|
||
|
||
def __get_tagged_version(node_id, table, tag, conn): | ||
"""Super private function to figure out the proper version number to use just after insertion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit picking: we might want to add the fact that we also set all existing node with same tag to be _sysan["latest"]=False
create_ng_tables(engine) | ||
|
||
|
||
def create_ng_tables(engine): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Adds support for tagging nodes based on properties set in the dictionary. Adds the following sysan properties
These values are evaluated using properties defined in the dictionary (currently only biodictionary defines those properties). The property name is
tagProperties
. See wiki for more description on how the versioning is expected to workThis PR enables automatically setting these values and querying nodes via these properties.
To get all version 2 nodes one can do this
to get all nodes with tag = "tag_1"