This repository has been archived by the owner on Jul 9, 2024. It is now read-only.
🐛 PRTL-854 Quick Search UI fixes #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SidSyrus
reviewed
Mar 16, 2017
| @@ -63,10 +80,11 @@ compose( | |||
| withRouter, | |||
| withHandlers({ | |||
| handleQueryChange: ({ api = API, setState }) => _.debounce(async (query) => { | |||
| api = 'https://gdc-api.nci.nih.gov/'; | |||
There was a problem hiding this comment.
I guess you are going to remove this before merging?
cheapsteak
force-pushed
the
fix/854-quicksearch
branch
from
369b286
to
893a7ae
Compare
cheapsteak
force-pushed
the
fix/854-quicksearch
branch
from
893a7ae
to
165b1a5
Compare
Jephuff
reviewed
Mar 17, 2017
| @@ -66,7 +83,7 @@ compose( | |||
| setState(s => ({ ...s, query, isLoading: true })); | |||
| const timeOfCurrentRequest = new Date().getTime(); | |||
| timeOfMostRecentRequest = timeOfCurrentRequest; | |||
| const url = `${api}all?fields=${SEARCH_FIELDS.join(',')}&query=${window.encodeURIComponent(query)}&size=10`; | |||
| const url = `${api}all?fields=${SEARCH_FIELDS.join(',')}&query=${window.encodeURIComponent(query)}&size=5`; | |||
There was a problem hiding this comment.
since your updating this line, you could switch it to use this function https://github.com/NCI-GDC/portal-ui/blob/relay/modules/node_modules/%40ncigdc/utils/ajax/index.js#L28
Jephuff
approved these changes
Mar 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA relevant tickets:
https://jira.opensciencedatacloud.org/browse/PRTL-860
https://jira.opensciencedatacloud.org/browse/PRTL-861
https://jira.opensciencedatacloud.org/browse/PRTL-862