Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CR: Change Primary Vivid Token to Cerulean-60v #1479

Closed
andyvanavery31 opened this issue Jan 11, 2024 · 1 comment · Fixed by #1482
Closed

CR: Change Primary Vivid Token to Cerulean-60v #1479

andyvanavery31 opened this issue Jan 11, 2024 · 1 comment · Fixed by #1482
Assignees
@dlescarbeau
Labels
Change Request Request to update or change existing requirements Documentation Improvements or additions to documentation Fix per Feedback Needs Technical Review Needs review from Architect and Development

Comments

@andyvanavery31
Copy link

andyvanavery31 commented Jan 11, 2024 •
edited by olitharp-nci

Change Request

  • Change $theme-color-primary-vivid to cerulean-60v
  • Change $theme-link-color to $theme-color-primary-vivid
  • Change the heading for nci-card to use $theme-link-color
    • Use mixin typeset-link. Which also sets text-decoration.

What's the expected change?

  • Change the requested colors to their requested updated color as described above

What's the current functionality?

  • The colors listed above are in their original color as indicated above

Related Tickets
@andyvanavery31 andyvanavery31 added Change Request Request to update or change existing requirements Documentation Improvements or additions to documentation labels Jan 11, 2024
This was referenced Jan 11, 2024
Closed
Closed
@olitharp-nci
Copy link
Contributor

olitharp-nci commented Jan 11, 2024 •
edited

Confirming I only found a component link issue in nci-card - please use the appropriate mixin instead here

dlescarbeau added a commit that referenced this issue Jan 17, 2024
@dlescarbeau
($1479) Updates link color of card heading
04d3fb5 
Closes #1479
dlescarbeau added a commit that referenced this issue Jan 17, 2024
@dlescarbeau
($1479) Updates link color of card heading
e547639 
Closes #1479
dlescarbeau added a commit that referenced this issue Jan 17, 2024
@dlescarbeau
($1479) Updates link color of card heading
9af957e 
Closes #1479
@dlescarbeau dlescarbeau mentioned this issue Jan 17, 2024
Merged
dlescarbeau added a commit that referenced this issue Jan 17, 2024
@dlescarbeau
(#1479) Updates link color of card heading
180604d 
Closes #1479
dlescarbeau added a commit that referenced this issue Jan 17, 2024
@dlescarbeau
(#1479) Updates link color of card heading
476e4e7 
Closes #1479
dlescarbeau added a commit that referenced this issue Jan 17, 2024
@dlescarbeau
(#1479) Updates link color of card heading
a48f76f 
Closes #1479
dlescarbeau added a commit that referenced this issue Jan 17, 2024
@dlescarbeau
(#1479) Updates link color of card heading
09dd8b8 
Closes #1479
@bennettcc bennettcc added Needs Technical Review Needs review from Architect and Development Needs Product Review Needs review from Product, QA, Design, and IA Fix per Feedback and removed Needs Product Review Needs review from Product, QA, Design, and IA labels Jan 18, 2024
olitharp-nci pushed a commit that referenced this issue Jan 18, 2024
@dlescarbeau @olitharp-nci
(#1479) Updates link color of card heading
ac0b054 
Closes #1479
This was referenced Apr 3, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlescarbeau dlescarbeau

Labels
Change Request Request to update or change existing requirements Documentation Improvements or additions to documentation Fix per Feedback Needs Technical Review Needs review from Architect and Development
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(#1479) Updates link color of card heading NCIOCPL/ncids
4 participants
@bennettcc @dlescarbeau @olitharp-nci @andyvanavery31