Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#1479) Updates link color of card heading #1482

Merged
merged 1 commit into from
Jan 18, 2024
Merged

(#1479) Updates link color of card heading #1482

merged 1 commit into from
Jan 18, 2024

Conversation

dlescarbeau
Copy link
Collaborator

@dlescarbeau dlescarbeau commented Jan 17, 2024 •
edited

@github-actions GitHub Actions
Copy link

Viewing Information

@dlescarbeau dlescarbeau force-pushed the ticket/1479-change-primary-vivid branch 2 times, most recently from 180604d to 476e4e7 Compare January 17, 2024 18:35
@dlescarbeau dlescarbeau requested a review from a team as a code owner January 17, 2024 18:35
@dlescarbeau dlescarbeau force-pushed the ticket/1479-change-primary-vivid branch from 476e4e7 to a48f76f Compare January 17, 2024 18:49
@dlescarbeau dlescarbeau force-pushed the ticket/1479-change-primary-vivid branch from a48f76f to 09dd8b8 Compare January 17, 2024 19:10
@andyvanavery31
Copy link

The changes look good to me.

@adrianacastaneda
Copy link

Changes look good to me as well

blilianyu
blilianyu reviewed Jan 18, 2024
View reviewed changes
Copy link
Contributor

@blilianyu blilianyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great!

@sarinapadilla sarinapadilla requested a review from a team January 18, 2024 14:38
sarinapadilla
sarinapadilla approved these changes Jan 18, 2024
View reviewed changes
Copy link

@sarinapadilla sarinapadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This passes product review!

@dlescarbeau dlescarbeau changed the title ($1479) Updates link color of card heading (#1479) Updates link color of card heading Jan 18, 2024
@dlescarbeau
Copy link
Collaborator Author

For clarification, we're setting the colors of the heading/link specifically for the CARD's interactions (visited, hover, focus, active), which is why they are copied from USWDS rather than simply using typeset-link which only handles the link's interactions.

These colors are pulled from USWDS, specifically the typeset-link mixin at uswds/packages/uswds-core/src/styles/mixins/typography/typeset.scss.

We omit the focus-outline present in USWDS from our card's focus interaction because the card itself is outlined on focus, and the focus on the title is decidedly unnecessary.

@olitharp-nci olitharp-nci merged commit ac0b054 into develop Jan 18, 2024
3 checks passed
@olitharp-nci olitharp-nci deleted the ticket/1479-change-primary-vivid branch January 18, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blilianyu blilianyu blilianyu left review comments

@sarinapadilla sarinapadilla sarinapadilla approved these changes

@olitharp-nci olitharp-nci olitharp-nci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CR: Change Primary Vivid Token to Cerulean-60v
6 participants
@dlescarbeau @andyvanavery31 @adrianacastaneda @sarinapadilla @blilianyu @olitharp-nci