feat: add e2e tests #135
Merged
feat: add e2e tests #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Change the export type of 'Course'
ppodds
requested changes
Oct 24, 2022
backend/src/app.module.ts
Outdated
| AuthModule, | ||
| // AuthModule, |
| course.departmentId = 'csie'; | ||
| await this.courseRepository.save(course); | ||
|
|
||
| for (let i = 0; i < 200; i++) { |
There was a problem hiding this comment.
Because I need to test changing the courses pages.
There was a problem hiding this comment.
Would the test pass if we only have 100 courses? You should consider the minimal test data.
| ) {} | ||
|
|
||
| async seedCourse() { | ||
| await this.courseRepository.clear(); |
There was a problem hiding this comment.
Could you extract it into the npm script?
Co-authored-by: ppodds <oscar20020629@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.