Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pheno modeling tutorial to website #425

Merged
merged 2 commits into from
Dec 7, 2018
Merged

Conversation

mjones01
Copy link
Contributor

@mjones01 mjones01 commented Dec 7, 2018

No description provided.

@mjones01
Copy link
Contributor Author

mjones01 commented Dec 7, 2018

@khufkens This tutorial looks great. I have moved it from tutorials-in-development to tutorials and will merge this PR when so that I can preview on the website tomorrow AM. However, we can still make any changes you'd like. And I won't publish on the website until you approve.
Please read through the full tutorial to make sure I didn't mis-characterize anything in my attempt to add some context in some areas.

I did some reorganization of the content for the this online version, as people will use it outside of the workshop -- you can still teach it any way you'd want (your original file is still in "tutorials-in-development" and I'll leave them there until after the workshop). Primarily I moved all the PEP725 content to the end and collected it into one section. I though this was more straight forward for someone without an instructor.

In addition, please see areas that could use more clarification (line #s in the RMD):
line 253. You cited Richardson 2018. Did I link the correct paper?
line 295. I don't understand (_foo/bar/) in this context, can you clarify.
line 524. There is a string of abbreviations here that I don't know what they mean and are not explained. Can you define them in the text?

I also switched to the US spelling of modeling so that it was consistent across the NEON website.

I was also a bit confused about the sections at the end of Phenology and Climate data where you link to the subsetted data. Please read through what I wrote to make sure I didn't mess anything up. Also, people do not need to download the data at this point as the data are read in directly in the modeling code, correct.

If you don't agree with anything I did, please submit changes directly. Please make modifications to the .RMD in the tutorials/R/Phenocam and submit as a PR. I'll re-knit for any changes with the special script so that images & code files end up in the correct location.

Thank you!!!

@mjones01 mjones01 merged commit 89f3e40 into NEONScience:master Dec 7, 2018
@khufkens
Copy link
Contributor

khufkens commented Dec 7, 2018

Corrections are here,
#426

I couldn't render the file so you need to spot check if this runs all code nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants