v 3.3.0 fails to start after installation

[bncbodrogi]

Issue description

Tried to install v 3.3.0, it seems to be successful but after executing yarn start it throws exceptions.
Please note that I have very limited experience with node also my packages might be messed up.

Steps to reproduce

1. git clone git@github.com:NERDDISCO/luminave.git
2. cd luminave
3. yarn
4. npm install -g polymer-cli
5. yarn start

Stacktrace

./node_modules/@material/mwc-button/mwc-button.js
[0] Module not found: Error: Can't resolve 'lit-html/directives/classMap.js' in '/Users/bence/Documents/DUNARNIA/VISUAL/luminave/node_modules/@material/mwc-button'
[0]  @ ./node_modules/@material/mwc-button/mwc-button.js 18:0-57 69:34-42
[0]  @ ./src/components/venue/manager.js
[0]  @ ./src/views/venue-view.js
[0]  @ ./src/actions/app.js
[0]  @ ./src/components/luminave-dashboard/index.js
[0]  @ ./src/app.js
[0]  @ ./src/index.js
 @ multi ./src webpack-dev-server/client?http://0.0.0.0:8081 webpack/hot/dev-server./node_modules/@material/mwc-ripple/mwc-ripple.js
[0] Module not found: Error: Can't resolve 'lit-html/directives/classMap.js' in '/Users/bence/Documents/DUNARNIA/VISUAL/luminave/node_modules/@material/mwc-ripple'
[0]  @ ./node_modules/@material/mwc-ripple/mwc-ripple.js 18:0-57 96:39-47
[0]  @ ./node_modules/@material/mwc-button/mwc-button.js
[0]  @ ./src/components/venue/manager.js
[0]  @ ./src/views/venue-view.js
[0]  @ ./src/actions/app.js
[0]  @ ./src/components/luminave-dashboard/index.js
[0]  @ ./src/app.js
[0]  @ ./src/index.js
[0]  @ multi ./src webpack-dev-server/client?http://0.0.0.0:8081 webpack/hot/dev-server./src/components/integration/integration-configuration.js
[0] Module not found: Error: Can't resolve 'lit-html/directives/classMap.js' in '/Users/bence/Documents/DUNARNIA/VISUAL/luminave/src/components/integration'
[0]  @ ./src/components/integration/integration-configuration.js 3:0-59 134:20-28
[0]  @ ./src/components/fivetwelve/fivetwelve-manager.js
[0]  @ ./src/components/luminave-menu/index.js
[0]  @ ./src/app.js
[0]  @ ./src/index.js
 @ multi ./src webpack-dev-server/client?http://0.0.0.0:8081 webpack/hot/dev-server./src/components/midi-grid/index.js
[0] Module not found: Error: Can't resolve 'lit-html/directives/classMap.js' in '/Users/bence/Documents/DUNARNIA/VISUAL/luminave/src/components/midi-grid'
[0]  @ ./src/components/midi-grid/index.js 9:0-59 153:87-95 261:30-38
[0]  @ ./src/components/midi-controller/index.js
[0]  @ ./src/components/midi-manager/index.js
[0]  @ ./src/views/midi-view.js
[0]  @ ./src/actions/app.js
[0]  @ ./src/components/luminave-dashboard/index.js
[0]  @ ./src/app.js
[0]  @ ./src/index.js
 @ multi ./src webpack-dev-server/client?http://0.0.0.0:8081 webpack/hot/dev-server./src/components/modv/modv-color-grid.js
[0] Module not found: Error: Can't resolve 'lit-html/directives/classMap.js' in '/Users/bence/Documents/DUNARNIA/VISUAL/luminave/src/components/modv'
[0]  @ ./src/components/modv/modv-color-grid.js 3:0-59 224:16-24
[0]  @ ./src/components/modv/modv-mapper.js
[0]  @ ./src/views/venue-detail-view.js
[0]  @ ./src/actions/app.js
[0]  @ ./src/components/luminave-dashboard/index.js
[0]  @ ./src/app.js
[0]  @ ./src/index.js
 @ multi ./src webpack-dev-server/client?http://0.0.0.0:8081 webpack/hot/dev-server./src/components/venue/slot-grid.js
[0] Module not found: Error: Can't resolve 'lit-html/directives/classMap.js' in '/Users/bence/Documents/DUNARNIA/VISUAL/luminave/src/components/venue'
[0]  @ ./src/components/venue/slot-grid.js 11:0-59 231:29-37
[0]  @ ./src/views/venue-detail-view.js
[0]  @ ./src/actions/app.js
[0]  @ ./src/components/luminave-dashboard/index.js
[0]  @ ./src/app.js
[0]  @ ./src/index.js
[0]  @ multi ./src webpack-dev-server/client?http://0.0.0.0:8081 webpack/hot/dev-server./src/components/venue/slot-item.js
[0] Module not found: Error: Can't resolve 'lit-html/directives/classMap.js' in '/Users/bence/Documents/DUNARNIA/VISUAL/luminave/src/components/venue'
[0]  @ ./src/components/venue/slot-item.js 8:0-59 187:29-37
[0]  @ ./src/components/venue/slot-grid.js
[0]  @ ./src/views/venue-detail-view.js
[0]  @ ./src/actions/app.js
[0]  @ ./src/components/luminave-dashboard/index.js
[0]  @ ./src/app.js
[0]  @ ./src/index.js
[0]  @ multi ./src webpack-dev-server/client?http://0.0.0.0:8081 webpack/hot/dev-server./src/components/venue/slot-item.js
[0] Module not found: Error: Can't resolve 'lit-html/directives/when.js' in '/Users/bence/Documents/DUNARNIA/VISUAL/luminave/src/components/venue'
[0]  @ ./src/components/venue/slot-item.js 6:0-51 186:8-12 191:12-16 203:12-16 226:12-16
[0]  @ ./src/components/venue/slot-grid.js
[0]  @ ./src/views/venue-detail-view.js
[0]  @ ./src/actions/app.js
[0]  @ ./src/components/luminave-dashboard/index.js
[0]  @ ./src/app.js
[0]  @ ./src/index.js
 @ multi ./src webpack-dev-server/client?http://0.0.0.0:8081 webpack/hot/dev-server./src/components/luminave-status/index.js 28:31-53
[0] "export 'getFivetwelveConnected' was not found in '../../selectors/index.js'
[0]  @ ./src/components/luminave-menu/index.js
[0]  @ ./src/app.js
[0]  @ ./src/index.js
[0]  @ multi ./src webpack-dev-server/client?http://0.0.0.0:8081 webpack/hot/dev-server./src/components/fivetwelve/fivetwelve-manager.js 133:4-21
[0] "export 'setFivetwelveData' was not found in '../../utils/index.js'
[0]  @ ./src/components/luminave-menu/index.js
[0]  @ ./src/app.js
[0]  @ ./src/index.js
 @ multi ./src webpack-dev-server/client?http://0.0.0.0:8081 webpack/hot/dev-server

Versions

1. luminave: 3.3.0

[TimPietrusky]

@bncbodrogi please try it like this:

git clone git@github.com:NERDDISCO/luminave.git
cd luminave
npm install
npm start

The yarn build is broken, because of incompatibilities of the packages I'm using. Only the npm build works, as we have a package-lock.json which is used while installing everything. And in there the packages are in their correct version.

I will fix that problem in the next version, but for now it should do the trick,.

[lezsakdomi]

Can confirm both the issue and the solution.

Came here only after found out :/

[lezsakdomi]

I have to note that adding lit-html manually (i.e. yarn add) won't fix the issue, even from inside ./node-modules/@material/mwc-button.

[TimPietrusky]

The problem is that lit-html removed when.js and renamed classMap.js to class-map.js in a minor-version (of course they can do that as there is no 1.0 release yet).

The fix is to update to the latest lit-html and update all occurences of classMap. And of course remove the one when. I already did this, I just need to create a PR.

[TimPietrusky]

🎉 This issue has been resolved in version 3.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[TimPietrusky]

@bncbodrogi @lezsakdomi I updated some dependencies and fixed the code that was deprecated after the update. I also improved the README to only use npm to install things, which will make sure that everyone is using the same setup as I do.

If you have the time, please do the setup again and tell me if it's working for you.