Add images directory #143
Add images directory #143
Conversation
|
@hlapp, Do you have any input? |
|
I was going to look at it in more detail. Re: licenses, IMHO there's no reason not to apply CC-BY to all images regardless of their format, and it looks like the SVG as it's written has the namespace (xmlns:cc="http://creativecommons.org/ns#") and means (<metadata/>) already predefined for asserting the license right within the file itself; the tool that writes it (Inkscape?) just needs to be told the appropriate value to put there. |
|
ping |
|
@hlapp, would you be okay merging this? IMO, it should be merged before we submit the paper so that it has precedence regarding the license. |
|
Sorry I somehow missed the fact that you had added fixes and mistakenly thought that I had to tweak something here. This looks perfect. I'm going ahead to merge. Sorry for the delay, and great fix to the SVG! |
More precisely, fix the deploy step timeout. The build actually succeeds, which presumably is why there wasn't any issue with the test on PR #143. The build with failed deploy step is here: https://circleci.com/gh/NESCent/popgenInfo/428
No worries, it makes me feel like I've accomplished something! 😹 |
This additionally adds figure 1 for the paper. The SVG file falls under MIT, but does the image require a CC-BY?