-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZAPD silently allows Blob
without Offset
#171
Comments
This has been a "feature" since day one (or at least since I joined). I'm not a huge fan tho |
So what offset does it default to? This behavior may make sense if the xml was meant to have the data in the same order as the file, but that's not the case in many xmls. |
It gets the offset of the last element plus its size. |
the last element as in, |
The last element read. The one just behind it. |
This may also be true for other things than
Blob
, didn't test ithttps://github.com/zeldaret/oot/blob/master/assets/xml/objects/gameplay_field_keep.xml#L58
<Blob Name="gFieldUnaccounted_00CB30" Size="0x800"/>
I would expect this to fail on extraction, or at least warn about it (missing
Offset
attribute), but ZAPD says nothing.The
Name
does end up being used (changing it also changes the extracted .c), so ZAPD must be doing some nice magic to still find the right offset for the data.Good job ZAPD but I guess this could be messed up by moving nodes around in the xml?
I tried moving the
Blob
withoutOffset
up in the file and then it got silently ignoredThe text was updated successfully, but these errors were encountered: