Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Limb>: Type vs LimbType #172

Closed
Dragorn421 opened this issue Aug 26, 2021 · 1 comment
Closed

<Limb>: Type vs LimbType #172

Dragorn421 opened this issue Aug 26, 2021 · 1 comment

Comments

@Dragorn421
Copy link
Contributor

Dragorn421 commented Aug 26, 2021

in the oot repo both <Limb Type="..."> and <Limb LimbType="..."> are used

$ grep -r assets/xml/ -e 'Limb.*\bLimbType' | wc --lines
2169
$ grep -r assets/xml/ -e 'Limb.*\bType' | wc --lines
427

From https://github.com/zeldaret/ZAPD/blob/master/docs/zapd_extraction_xml_reference.md#limb I assume the correct one is LimbType

ZAPD should at least warn about a missing "LimbType" because I assume all those <Limb>s setting Type just have the Type value ignored

I assume LimbType defaults to Standard, everything setting Type uses Standard except object_link_child.xml which has some Type="LOD"

EDIT: I don't even think ZAPD knows what it's doing
https://github.com/zeldaret/ZAPD/blob/82bd27604a4c8f8c1f01f9c2f54c87fab103c39f/ZAPD/ZLimb.cpp#L381-L384
Does this mean Type and LimbType are "aliases", is that intended

@AngheloAlf
Copy link
Contributor

Yes, Type and LimbType are alliases between them.
We could deprecate Type if people feel like we should do it.

Dragorn421 added a commit to Dragorn421/Z64Utils that referenced this issue Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants