We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<Limb>
Type
LimbType
in the oot repo both <Limb Type="..."> and <Limb LimbType="..."> are used
<Limb Type="...">
<Limb LimbType="...">
$ grep -r assets/xml/ -e 'Limb.*\bLimbType' | wc --lines 2169 $ grep -r assets/xml/ -e 'Limb.*\bType' | wc --lines 427
From https://github.com/zeldaret/ZAPD/blob/master/docs/zapd_extraction_xml_reference.md#limb I assume the correct one is LimbType
ZAPD should at least warn about a missing "LimbType" because I assume all those <Limb>s setting Type just have the Type value ignored
I assume LimbType defaults to Standard, everything setting Type uses Standard except object_link_child.xml which has some Type="LOD"
Standard
object_link_child.xml
Type="LOD"
EDIT: I don't even think ZAPD knows what it's doing https://github.com/zeldaret/ZAPD/blob/82bd27604a4c8f8c1f01f9c2f54c87fab103c39f/ZAPD/ZLimb.cpp#L381-L384 Does this mean Type and LimbType are "aliases", is that intended
The text was updated successfully, but these errors were encountered:
Yes, Type and LimbType are alliases between them. We could deprecate Type if people feel like we should do it.
Sorry, something went wrong.
Use either Type or LimbType for <Limb>
fba153b
See NEstelami/ZAPD#172
No branches or pull requests
in the oot repo both
<Limb Type="...">
and<Limb LimbType="...">
are usedFrom https://github.com/zeldaret/ZAPD/blob/master/docs/zapd_extraction_xml_reference.md#limb I assume the correct one is
LimbType
ZAPD should at least warn about a missing "LimbType" because I assume all those<Limb>
s settingType
just have theType
value ignoredI assumeLimbType
defaults toStandard
, everything settingType
usesStandard
exceptobject_link_child.xml
which has someType="LOD"
EDIT: I don't even think ZAPD knows what it's doing
https://github.com/zeldaret/ZAPD/blob/82bd27604a4c8f8c1f01f9c2f54c87fab103c39f/ZAPD/ZLimb.cpp#L381-L384
Does this mean Type and LimbType are "aliases", is that intended
The text was updated successfully, but these errors were encountered: