Change label and textual definition of VIBSO:0000002 (exposure time setting) to "integration time setting" #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zack-83
approved these changes
Feb 3, 2023
StroemPhi
added a commit
that referenced
this pull request
Feb 7, 2023
StroemPhi
added a commit
that referenced
this pull request
Feb 7, 2023
StroemPhi
commented
Feb 7, 2023
Comment on lines
+23
to
+24
| obo:VIBSO_0000017 total integration time https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/30 | ||
| obo:VIBSO_0000018 https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/30 |
There was a problem hiding this comment.
these two lines should not have been committed, this was an accident
StroemPhi
added a commit
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #40
This PR changes the label and definition of VIBSO:0000002 as suggested in this comment, because this fits the intended meaning better than the previous too general label & definition.