Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change label and textual definition of VIBSO:0000002 (exposure time setting) to "integration time setting" #56

Merged
merged 2 commits into from
Feb 3, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/templates/vibso_classes.tsv
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ id label alternative term link(s) to issue(s) definition definition source URI t
ID AL rdfs:label@en AL IAO:0000118@en SPLIT=| AI rdfs:seeAlso SPLIT=| AL IAO:0000115@en >AI dc11:source TYPE SC % SPLIT=| AI dc11:contributor SPLIT=| AL IAO:0000112@en AL IAO:0000116@en SPLIT=| AT owl:deprecated^^xsd:boolean AI IAO:0000231 AI IAO:0100001
obo:VIBSO_0000000 vibrational spectrometer configuration specification https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/39 A setting datum that specifies the needed settings of a spectrometer used in vibrational spectroscopy. owl:Class setting datum ORCID:0000-0002-1595-3213
obo:VIBSO_0000001 Raman spectrometer configuration https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/47 A device setting that represents the measured or set physical qualities which make up the configuration state of a Raman spectrometer at the time of a measurement (e.g. operating temperature, exitation wavelength, groove density, ...). owl:Class device setting ORCID:0000-0002-1595-3213 The set of meassured configuration characteristics of a Raman spectrometer, like the operating temperature of a Raman spectrometer.
obo:VIBSO_0000002 exposure time setting https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/40 A setting datum that specifies the duration in which an electromagnetic radiation beam is exposed to / recorded by a photosensor. owl:Class setting datum ORCID:0000-0002-1595-3213 This class should better be defined in a more general device ontology or a domain ontology with the scope of optical devices.
obo:VIBSO_0000002 integration time setting integration period setting https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/40 A setting datum that specifies the length of time that a photo detector is allowed to collect photons before passing the accumulated charge to the A/D converter for processing. The minimum integration time is the shortest integration time the device supports and is dependent on how fast the detector can read out all of the pixel information. Integration time should not be confused with data transfer speed. https://www.oceaninsight.com/knowledge-hub/glossary/#i owl:Class setting datum ORCID:0000-0002-1595-3213 This class should better be defined in a more general device ontology or a domain ontology with the scope of optical devices.
obo:VIBSO_0000003 preamplifier gain setting https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/41 A setting datum that specifies the preamplifier gain in CCD sensors. owl:Class setting datum ORCID:0000-0002-1595-3213 This class should better be defined in a more general device ontology.
obo:VIBSO_0000004 horizontal shift speed setting https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/42 A setting datum that specifies the horizontal shift speed in CCD sensors. owl:Class setting datum ORCID:0000-0002-1595-3213 This class should better be defined in a more general device ontology or a domain ontology with the scope of optical devices.
obo:VIBSO_0000005 vertical shift speed setting https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/42 A setting datum that specifies the vertical shift speed in CCD sensors. owl:Class setting datum ORCID:0000-0002-1595-3213 This class should better be defined in a more general device ontology or a domain ontology with the scope of optical devices.
Expand All @@ -20,3 +20,5 @@ example:objective_magnification_factor_setting_for_RamanSpectrometerX rdf:type o
obo:OBI_0002815 (has representation) '100 x' ."
obo:VIBSO_0000015 spectral window range maximum acquisition band maximum https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/31 A data item that is the part of a Raman spectrum which represents the maximum wavenumber included in the spectrum and which is calculated from the windows size and window center. owl:Class data item|('part of' some 'Raman spectrum') ORCID:0000-0002-1595-3213|ORCID:0000-0001-7694-5519 210 cm^-1 It needs to be determined, if this is also part of another kind of spectrum, such as a vibrational spectrum in general. We also need to decide, if we need to also model the terms window size and window center, from which this term is derived.
obo:VIBSO_0000016 spectral window range minimum acquisition band minimum https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/31 A data item that is the part of a Raman spectrum which represents the minimum wavenumber included in the spectrum and which is calculated from the windows size and window center. owl:Class data item|('part of' some 'Raman spectrum') ORCID:0000-0002-1595-3213|ORCID:0000-0001-7694-5519 1960 cm^-1 It needs to be determined, if this is also part of another kind of spectrum, such as a vibrational spectrum in general. We also need to decide, if we need to also model the terms window size and window center, from which this term is derived.
obo:VIBSO_0000017 total integration time https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/30
obo:VIBSO_0000018 https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/30
Comment on lines +23 to +24
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these two lines should not have been committed, this was an accident