Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change label and def of VIBSO:0000007 (number of scans) to "number of accumulations" #60

Merged
merged 9 commits into from
Feb 9, 2023

Conversation

Zack-83
Copy link
Collaborator

@Zack-83 Zack-83 commented Feb 8, 2023

Closes #30

@Zack-83 Zack-83 linked an issue Feb 8, 2023 that may be closed by this pull request
Copy link
Member

@StroemPhi StroemPhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zack-83, as you seem to have mentioned in #30 (comment), I would rather just change the label and adjust the textual definition of VIBSO_0000007 instead of minting a new term, as this was what what actually meant from my side behind this term.

@Zack-83
Copy link
Collaborator Author

Zack-83 commented Feb 8, 2023

Fine for me. The numbers 00000xx are in fact arbitrary, until we publish :)

@StroemPhi
Copy link
Member

@Zack-83 & @RainerStosch if you two are now fine with the definition:
A setting datum that specifies the desired number of measurements a spectrometer has to perform to produce an usable spectrum. then we can merge.

@StroemPhi
Copy link
Member

But please let me do the merge.

@Zack-83
Copy link
Collaborator Author

Zack-83 commented Feb 8, 2023

Fine for me.

@StroemPhi
Copy link
Member

Argh. I just saw that yo9ur (@Zack-83) edited the issue description, in which the textual definition is now:
The number of acquisitions on the same location, without position change. (Relevant to improve the S/N ratio.)
If you want me to adjust the one I have now, to reflect this please let me know and I will do it later today or tomorrow morning.

@Zack-83
Copy link
Collaborator Author

Zack-83 commented Feb 8, 2023

Your definition sounds more general. Ours is possibly more precise. Feel free to find a suitable compromise :)

@StroemPhi StroemPhi merged commit e54e374 into main Feb 9, 2023
@StroemPhi StroemPhi deleted the 30-ntr-add-number-of-accumulations branch February 9, 2023 11:08
@StroemPhi StroemPhi changed the title Add "number of accumulations" Change label and def of VIBSO:0000007 (number of scans) to "number of accumulations" Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NTR] add "number of accumulations"
2 participants