Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change label and def of VIBSO:0000007 (number of scans) to "number of accumulations" #60

Merged
merged 9 commits into from
Feb 9, 2023
Merged

Change label and def of VIBSO:0000007 (number of scans) to "number of accumulations" #60

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
68cde08
Add "number of accumulations"
Zack-83 Feb 8, 2023
d54d5d6
Replace 00017 with 00007
Zack-83 Feb 8, 2023
4a30a0c
Update src/templates/vibso_classes.tsv
Zack-83 Feb 8, 2023
66399fd
Update vibso_classes.tsv
Zack-83 Feb 8, 2023
84a4113
Merge branch 'main' into 30-ntr-add-number-of-accumulations
StroemPhi Feb 8, 2023
6de7bcb
Adjust VIBSO_0000007 to be the "number of accumulations" setting
StroemPhi Feb 8, 2023
b0c6c23
fix typoc
StroemPhi Feb 8, 2023
37d6be0
Update .gitignore
StroemPhi Feb 9, 2023
9a9b31e
Update the textual definition of VIBSO_0000007 (number of accumulations)
StroemPhi Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/templates/vibso_classes.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ obo:VIBSO_0000003 preamplifier gain setting https://github.com/NFDI4Chem/Vibrat
obo:VIBSO_0000004 horizontal shift speed setting https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/42 A setting datum that specifies the horizontal shift speed in CCD sensors. owl:Class setting datum ORCID:0000-0002-1595-3213 This class should better be defined in a more general device ontology or a domain ontology with the scope of optical devices.
obo:VIBSO_0000005 vertical shift speed setting https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/42 A setting datum that specifies the vertical shift speed in CCD sensors. owl:Class setting datum ORCID:0000-0002-1595-3213 This class should better be defined in a more general device ontology or a domain ontology with the scope of optical devices.
obo:VIBSO_0000006 device temperature setting https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/43 A setting datum that specifies the operating temperature of a device. owl:Class setting datum ORCID:0000-0002-1595-3213 This class should better be defined in a more general device ontology.
obo:VIBSO_0000007 number of scans setting https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/44 A setting datum that specifies the number of iterations performed in a spectroscopic meassurement from which an aggregated assay output is generated. owl:Class setting datum|('part of' some 'vibrational spectrometer configuration specification') ORCID:0000-0002-1595-3213 The setting entered into a Raman microscope which specifies the desired number of measurements this Raman microscope has to perform to produce an usable Raman spectrum. This class should better be defined in a more general device ontology.
obo:VIBSO_0000008 CCD sensor binning read mode setting https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/46 A setting datum that specifies the binning read mode of a device with a CCD sensor. owl:Class setting datum ORCID:0000-0002-1595-3213 This class should better be defined in a more general device ontology or a domain ontology with the scope of optical devices.
obo:VIBSO_0000009 groove density groove frequency https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/45 A physical quality inhering in a diffraction grating device by virtue of the device's function to diffract light. This quality specifically depends on the number of grooves per area of the grating device and is usually expressed in grooves per millimeter. Wikipedia:Diffraction_grating|https://www.meetoptics.com/academy/groove-density#:~:text=The%20groove%20density%20(or%20groove,of%20the%20operational%20wavelength%20range owl:Class physical quality ORCID:0000-0002-1595-3213 temp class until NTR in PATO has been accepted and merged (https://github.com/pato-ontology/pato/issues/541)
obo:VIBSO_0000010 groove density setting https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/45 A setting datum that specifies the number of grooves in a diffraction grating device. owl:Class setting datum ORCID:0000-0002-1595-3213 This class should better be defined in a more general device ontology or a domain ontology with the scope of optical devices.
Expand All @@ -20,5 +19,4 @@ example:objective_magnification_factor_setting_for_RamanSpectrometerX rdf:type o
obo:OBI_0002815 (has representation) '100 x' ."
obo:VIBSO_0000015 spectral window range maximum acquisition band maximum https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/31 A data item that is the part of a Raman spectrum which represents the maximum wavenumber included in the spectrum and which is calculated from the windows size and window center. owl:Class data item|('part of' some 'Raman spectrum') ORCID:0000-0002-1595-3213|ORCID:0000-0001-7694-5519 210 cm^-1 It needs to be determined, if this is also part of another kind of spectrum, such as a vibrational spectrum in general. We also need to decide, if we need to also model the terms window size and window center, from which this term is derived.
obo:VIBSO_0000016 spectral window range minimum acquisition band minimum https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/31 A data item that is the part of a Raman spectrum which represents the minimum wavenumber included in the spectrum and which is calculated from the windows size and window center. owl:Class data item|('part of' some 'Raman spectrum') ORCID:0000-0002-1595-3213|ORCID:0000-0001-7694-5519 1960 cm^-1 It needs to be determined, if this is also part of another kind of spectrum, such as a vibrational spectrum in general. We also need to decide, if we need to also model the terms window size and window center, from which this term is derived.
obo:VIBSO_0000017 total integration time https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/30
obo:VIBSO_0000018 https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/30
obo:VIBSO_0000017 number of accumulations number of acquisitions https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/issues/30