fix: remove duplicate e2e test run

NFDI4Chem · Mar 30, 2023 · ceb7474 · ceb7474
1 parent 3edc1b1
commit ceb7474
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 40 deletions.
diff --git a/.github/workflows/dev-build.yml b/.github/workflows/dev-build.yml
@@ -34,18 +34,22 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version: 18.x
       - name: Install dependencies
         run: npm ci
       - name: Install Playwright
         run: npx playwright install --with-deps
       - name: Build test application
-        env:
-          NODE_OPTIONS: '--max_old_space_size=4096'
         run: npm run build-no-minify
       - name: Run E2E tests on ${{ matrix.project }}
         run: npx playwright test --project ${{ matrix.project }}
         continue-on-error: ${{ matrix.project == 'webkit' }}
+      - name: Upload test results
+        if: always()
+        uses: actions/upload-artifact@v3
+        with:
+          name: test-results-${{ matrix.project }}
+          path: test-results
 
   lint:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml
@@ -26,18 +26,22 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version: 18.x
       - name: Install dependencies
         run: npm ci
       - name: Install Playwright
         run: npx playwright install --with-deps
       - name: Build test application
-        env:
-          NODE_OPTIONS: '--max_old_space_size=4096'
         run: npm run build-no-minify
       - name: Run E2E tests on ${{ matrix.project }}
         run: npx playwright test --project ${{ matrix.project }}
         continue-on-error: ${{ matrix.project == 'webkit' }}
+      - name: Upload test results
+        if: always()
+        uses: actions/upload-artifact@v3
+        with:
+          name: test-results-${{ matrix.project }}
+          path: test-results
 
   lint:
     runs-on: ubuntu-latest