Set guzzle timeout

NFarrington · Apr 29, 2018 · 72bc6c7 · 72bc6c7
1 parent 62a0d18
commit 72bc6c7
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/app/Libraries/Vatsim.php b/app/Libraries/Vatsim.php
@@ -3,7 +3,6 @@
 namespace App\Libraries;
 
 use App\Exceptions\Cert\InvalidResponseException;
-use GuzzleHttp\Client as GuzzleClient;
 use SimpleXMLElement;
 
 class Vatsim
@@ -17,7 +16,7 @@ class Vatsim
      */
     public function getUser(int $id)
     {
-        $client = app(GuzzleClient::class);
+        $client = app('guzzle');
         $url = "https://cert.vatsim.net/vatsimnet/idstatusint.php?cid={$id}";
         $res = $client->get($url);
 

diff --git a/app/Providers/AppServiceProvider.php b/app/Providers/AppServiceProvider.php
@@ -2,6 +2,7 @@
 
 namespace App\Providers;
 
+use GuzzleHttp\Client as GuzzleClient;
 use Illuminate\Support\Carbon;
 use Illuminate\Support\ServiceProvider;
 
@@ -47,6 +48,8 @@ public function boot()
      */
     public function register()
     {
-        //
+        $this->app->bind('guzzle', function () {
+            return new GuzzleClient(['timeout' => 5]);
+        });
     }
 }
diff --git a/tests/Unit/VatsimTest.php b/tests/Unit/VatsimTest.php
@@ -29,7 +29,7 @@ function can_retrieve_user_data_from_cert()
         ]);
         $handler = HandlerStack::create($mock);
         $client = new Client(['handler' => $handler]);
-        $this->app->instance(Client::class, $client);
+        $this->app->instance('guzzle', $client);
 
         $user = (new Vatsim)->getUser($template->id);
         $this->assertArraySubset([
@@ -52,7 +52,7 @@ function throws_exception_if_id_not_in_response()
         ]);
         $handler = HandlerStack::create($mock);
         $client = new Client(['handler' => $handler]);
-        $this->app->instance(Client::class, $client);
+        $this->app->instance('guzzle', $client);
 
         $this->expectException(InvalidResponseException::class);
         (new Vatsim)->getUser($template->id);
@@ -71,7 +71,7 @@ function throws_exception_if_missing_data()
         ]);
         $handler = HandlerStack::create($mock);
         $client = new Client(['handler' => $handler]);
-        $this->app->instance(Client::class, $client);
+        $this->app->instance('guzzle', $client);
 
         $this->expectException(InvalidResponseException::class);
         (new Vatsim)->getUser($template->id);