Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gesture support to Carousel #1816

Closed
wuiancocos2d opened this issue Jul 11, 2018 · 3 comments · Fixed by #1856
Closed

Add gesture support to Carousel #1816

wuiancocos2d opened this issue Jul 11, 2018 · 3 comments · Fixed by #1856
Assignees
@wzhudev
Labels
💪 Enhancement 💬 Discussion Need more insights to this issue

Comments

@wuiancocos2d
Copy link

What problem does this feature solve?

Add gesture animate to Carousel component , to improve the experience of phone user. Including , swap distance animate before next()/pre()

What does the proposed API look like?

[swapDistance], [ifGesture]
@hsuanxyz hsuanxyz added 💬 Discussion Need more insights to this issue 💪 Enhancement labels Jul 12, 2018
@wzhudev wzhudev self-assigned this Jul 17, 2018
@wzhudev
Copy link
Member

wzhudev commented Jul 17, 2018

Ant Design React supports swipe gesture. We should keep up.

@wzhudev wzhudev removed their assignment Jul 18, 2018
@vthinkxie
Copy link
Member

add support for hammerjs

wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this issue Jul 22, 2018
feat(carousel): add swipe gesture support
d82adef 
close NG-ZORRO#1816
wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this issue Jul 22, 2018
feat(carousel): add swipe gesture support
4be73a7 
close NG-ZORRO#1816
@wzhudev wzhudev mentioned this issue Jul 22, 2018
Merged
3 tasks
vthinkxie pushed a commit that referenced this issue Jul 22, 2018
@vthinkxie
feat(carousel): add swipe gesture support (#1856)
0c565ac 
close #1816
vthinkxie pushed a commit that referenced this issue Jul 22, 2018
feat(carousel): add swipe gesture support (#1856)
bb5bdd3 
close #1816
wenqi73 pushed a commit to wenqi73/ng-zorro-antd that referenced this issue Aug 27, 2018
@wenqi73
feat(carousel): add swipe gesture support (NG-ZORRO#1856)
184ca5e 
close NG-ZORRO#1816
@lock
Copy link

lock bot commented Jul 22, 2019

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 22, 2019
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
feat(carousel): add swipe gesture support (NG-ZORRO#1856)
fa685d0 
close NG-ZORRO#1816
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wzhudev wzhudev

Labels
💪 Enhancement 💬 Discussion Need more insights to this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(carousel): add swipe gesture support wzhudev/ng-zorro-antd
4 participants
@vthinkxie @wuiancocos2d @wzhudev @hsuanxyz