Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(carousel): add swipe gesture support #1856

Merged
merged 6 commits into from
Jul 22, 2018

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jul 22, 2018

close #1816

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1816

What is the new behavior?

When developers use hammer.js in their projects, users can switch carousel contents by swiping them.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@wzhudev wzhudev requested a review from vthinkxie July 22, 2018 07:46
@codecov
Copy link

codecov bot commented Jul 22, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@b0f9d7b). Click here to learn what that means.
The diff coverage is 47.36%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1856   +/-   ##
=========================================
  Coverage          ?   95.97%           
=========================================
  Files             ?      466           
  Lines             ?    11217           
  Branches          ?     1474           
=========================================
  Hits              ?    10766           
  Misses            ?      131           
  Partials          ?      320
Impacted Files Coverage Δ
components/carousel/nz-carousel.component.ts 90.07% <47.36%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f9d7b...47f4296. Read the comment docs.

@vthinkxie vthinkxie merged commit 0c565ac into NG-ZORRO:master Jul 22, 2018
vthinkxie pushed a commit that referenced this pull request Jul 22, 2018
@wzhudev wzhudev deleted the carousel-swipe branch July 24, 2018 08:58
wenqi73 pushed a commit to wenqi73/ng-zorro-antd that referenced this pull request Aug 27, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add gesture support to Carousel
2 participants