Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible? to custom spin indicator in all view with one templateRef #2792

Closed
9haroon opened this issue Jan 16, 2019 · 2 comments · Fixed by #4221
Closed

Is it possible? to custom spin indicator in all view with one templateRef #2792

9haroon opened this issue Jan 16, 2019 · 2 comments · Fixed by #4221
Assignees
@vthinkxie @wzhudev
Labels
🌈 Feature Request

Comments

@9haroon
Copy link

9haroon commented Jan 16, 2019

What problem does this feature solve?

How to custom spin indicator in all view with one templateRef
now nz-spin can custom via attribute "nzIndicator" with TemplateRef value's type, so that template should provide templateRef for all view that nzSpin is used.

What does the proposed API look like?

could it custom by provider in ngModule? like useValue
@hsuanxyz hsuanxyz added the 💬 Discussion Need more insights to this issue label Jan 16, 2019
@wzhudev
Copy link
Member

wzhudev commented Jan 16, 2019

Like Empty component, some components used by our own components should provide a unified way for users to set default content.

@9haroon
Copy link
Author

9haroon commented Jan 16, 2019

Could you give me an example?

@vthinkxie vthinkxie mentioned this issue Feb 19, 2019
Closed
@vthinkxie vthinkxie self-assigned this Feb 26, 2019
@timadevelop timadevelop mentioned this issue May 20, 2019
Open
30 tasks
@wzhudev wzhudev self-assigned this Sep 26, 2019
@wzhudev wzhudev mentioned this issue Sep 26, 2019
Merged
3 tasks
@wzhudev wzhudev added 🌈 Feature Request and removed 📋 Backlog 💬 Discussion Need more insights to this issue labels Sep 26, 2019
vthinkxie pushed a commit that referenced this issue Oct 14, 2019
@vthinkxie
feat(module:spin): support global indicator (#4221)
a7ecb8b 
close #2792
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@Ricbet
feat(module:spin): support global indicator (NG-ZORRO#4221)
7dd1f55 
close NG-ZORRO#2792
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@vthinkxie
feat(module:spin): support global indicator (NG-ZORRO#4221)
e666eb4 
close NG-ZORRO#2792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vthinkxie vthinkxie

@wzhudev wzhudev

Labels
🌈 Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(module:spin): support global indicator wzhudev/ng-zorro-antd
4 participants
@vthinkxie @wzhudev @hsuanxyz @9haroon