Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order of DOM nodes in a button is not respected #3079

Closed
chabb opened this issue Mar 12, 2019 · 1 comment · Fixed by #3578
Closed

Order of DOM nodes in a button is not respected #3079

chabb opened this issue Mar 12, 2019 · 1 comment · Fixed by #3578
Assignees
@vthinkxie
Labels
🐛 Bug Component: Button

Comments

@chabb
Copy link

chabb commented Mar 12, 2019 •
edited
Loading

Reproduction link

https://ng-zorro-antd-start-vjhban.stackblitz.io

Steps to reproduce

Make a component with an input. Use a button with an icon. Use interpolation in the view to display some text before the icon. It does not work.
It works when theres is no binding/interpolation in the HTML

What is expected?

The order of the HTML should be respected

What is actually happening?

The order is not respected. The icon comes before the text

It might because of the moveIcon method in nz-button-component.ts. I am taking a look

Environment Info
ng-zorro-antd 7.0.2
Browser Chrome latest
@wzhudev
Copy link
Member

wzhudev commented Mar 13, 2019 •
edited
Loading

Boilerplate related.

@vthinkxie vthinkxie mentioned this issue Jun 15, 2019
Merged
3 tasks
vthinkxie added a commit that referenced this issue Jun 15, 2019
@vthinkxie
fix(module:button): fix order of DOM nodes in button (#3578)
c3df8b5 
close #3079
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@vthinkxie @Ricbet
fix(module:button): fix order of DOM nodes in button (NG-ZORRO#3578)
2844f39 
close NG-ZORRO#3079
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@vthinkxie
fix(module:button): fix order of DOM nodes in button (NG-ZORRO#3578)
e6ea042 
close NG-ZORRO#3079
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vthinkxie vthinkxie

Labels
🐛 Bug Component: Button
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(module:button): fix order of DOM nodes in button
3 participants
@vthinkxie @chabb @wzhudev