Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix type of some API #3166

Merged
merged 5 commits into from
Mar 27, 2019
Merged

fix: fix type of some API #3166

merged 5 commits into from
Mar 27, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Mar 26, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe: Fix type of some API. Otherwise some editors would complain about incorrect types

image

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Mar 26, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 246595a

https://deploy-preview-3166--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #3166 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3166   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         552      552           
  Lines       11587    11587           
  Branches      827      827           
=======================================
  Hits        11279    11279           
  Misses        195      195           
  Partials      113      113
Impacted Files Coverage Δ
components/tooltip/nz-tooltip.component.ts 92.18% <100%> (ø) ⬆️
components/modal/nz-modal.component.ts 99.01% <100%> (ø) ⬆️
components/table/nz-table.component.ts 97.76% <100%> (ø) ⬆️
components/tooltip/nz-tooltip.directive.ts 98.8% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e0e319...246595a. Read the comment docs.

@vthinkxie vthinkxie merged commit c685836 into NG-ZORRO:master Mar 27, 2019
@wzhudev wzhudev deleted the type-adjust branch March 28, 2019 03:43
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* fix: fix type of some API

* fix: table

* fix: fix nullale API

* feat(module:table): use generic typing

* fix: fix generic type
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* fix: fix type of some API

* fix: table

* fix: fix nullale API

* feat(module:table): use generic typing

* fix: fix generic type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants