Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a click event to nz-rate #3252

Closed
martani opened this issue Apr 11, 2019 · 2 comments · Fixed by #3262
Closed

Add a click event to nz-rate #3252

martani opened this issue Apr 11, 2019 · 2 comments · Fixed by #3262
Assignees
@wzhudev
Labels
🐛 Bug Component: Rate

Comments

@martani
Copy link

martani commented Apr 11, 2019

What problem does this feature solve?

It would be useful to expose a click event on nz-rate. In my case, I want to show the user a popover to enter feedback.

What does the proposed API look like?

[nzClick]="ClickHandler($event)"
@wzhudev
Copy link
Member

wzhudev commented Apr 12, 2019

click is a native DOM event.

@wzhudev wzhudev closed this as completed Apr 12, 2019
@martani
Copy link
Author

martani commented Apr 12, 2019

The native click event does not get triggered when you click on the stars themselves. It's only triggered when you clean on the empty space between the stars. Here is a repro: https://stackblitz.com/edit/angular-c22cjy

@wzhudev wzhudev reopened this Apr 12, 2019
wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this issue Apr 12, 2019
fix: click event is stopped
86568bb 
close NG-ZORRO#3252
@wzhudev wzhudev mentioned this issue Apr 12, 2019
Merged
3 tasks
hsuanxyz pushed a commit that referenced this issue Apr 19, 2019
@hsuanxyz
fix: click event is stopped (#3262)
2b4bde4 
close #3252
andrew-yangy pushed a commit to andrew-yangy/ng-zorro-antd that referenced this issue Jun 20, 2019
@andrew-yangy
fix: click event is stopped (NG-ZORRO#3262)
49c3277 
close NG-ZORRO#3252
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@Ricbet
fix: click event is stopped (NG-ZORRO#3262)
978e5ea 
close NG-ZORRO#3252
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@hsuanxyz
fix: click event is stopped (NG-ZORRO#3262)
45854ab 
close NG-ZORRO#3252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wzhudev wzhudev

Labels
🐛 Bug Component: Rate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: click event is stopped wzhudev/ng-zorro-antd
2 participants
@martani @wzhudev