Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:button): fix order of DOM nodes in button #3578

Merged
merged 1 commit into from
Jun 15, 2019
Merged

fix(module:button): fix order of DOM nodes in button #3578

merged 1 commit into from
Jun 15, 2019

Conversation

vthinkxie
Copy link
Member

close #3079

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@netlify
Copy link

netlify bot commented Jun 15, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 97c5f6c

https://deploy-preview-3578--ng-zorro-master.netlify.com

@netlify
Copy link

netlify bot commented Jun 15, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 834c2c8

https://deploy-preview-3578--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jun 15, 2019

Codecov Report

Merging #3578 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3578      +/-   ##
==========================================
+ Coverage    95.7%   95.73%   +0.02%     
==========================================
  Files         690      690              
  Lines       13699    13708       +9     
  Branches     1823     1824       +1     
==========================================
+ Hits        13111    13123      +12     
+ Misses        200      198       -2     
+ Partials      388      387       -1
Impacted Files Coverage Δ
components/button/nz-button.component.ts 95% <100%> (+0.63%) ⬆️
components/select/nz-option-container.component.ts 97.67% <0%> (+2.32%) ⬆️
components/core/util/dom.ts 91.17% <0%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e84e8...834c2c8. Read the comment docs.

@vthinkxie vthinkxie merged commit c3df8b5 into NG-ZORRO:master Jun 15, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order of DOM nodes in a button is not respected
1 participant