Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(module:mention): support for adaptive boundary #4263

Merged
merged 2 commits into from
Oct 14, 2019
Merged

feat(module:mention): support for adaptive boundary #4263

merged 2 commits into from
Oct 14, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4260

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@auto-assign auto-assign bot requested a review from wenqi73 October 10, 2019 09:17
@codecov
Copy link

codecov bot commented Oct 10, 2019 •
edited
Loading

Codecov Report

Merging #4263 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4263      +/-   ##
==========================================
+ Coverage   92.18%   92.19%   +<.01%     
==========================================
  Files         520      520              
  Lines       11005    11005              
  Branches     1995     1995              
==========================================
+ Hits        10145    10146       +1     
  Misses        429      429              
+ Partials      431      430       -1
Impacted Files Coverage Δ
components/core/overlay/overlay-position.ts 100% <100%> (ø) ⬆️
components/mention/nz-mention.component.ts 98.59% <100%> (ø) ⬆️
components/time-picker/time-holder.ts 97.36% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1bba9e...57b0cb2. Read the comment docs.

@netlify
Copy link

netlify bot commented Oct 10, 2019 •
edited
Loading

Deploy preview for ng-zorro-master ready!

Built with commit 57b0cb2

https://deploy-preview-4263--ng-zorro-master.netlify.com

vthinkxie
vthinkxie requested changes Oct 12, 2019
View reviewed changes
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default styles change

@weekly-digest weekly-digest bot mentioned this pull request Oct 13, 2019
Closed
wzhudev
wzhudev approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 812e1c5 into NG-ZORRO:master Oct 14, 2019
@weekly-digest weekly-digest bot mentioned this pull request Oct 20, 2019
Closed
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@hsuanxyz @Ricbet
feat(module:mention): support for adaptive boundary (NG-ZORRO#4263)
fa4b672 
* feat(module:mention): support for adaptive boundary

close NG-ZORRO#4260

* chore: adjustment menu position
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz @vthinkxie
feat(module:mention): support for adaptive boundary (NG-ZORRO#4263)
c9da322 
* feat(module:mention): support for adaptive boundary

close NG-ZORRO#4260

* chore: adjustment menu position
@hsuanxyz hsuanxyz deleted the feat/mention-auto-position branch August 5, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vthinkxie vthinkxie vthinkxie requested changes

@wzhudev wzhudev wzhudev approved these changes

@wenqi73 wenqi73 Awaiting requested review from wenqi73

Assignees

@wzhudev wzhudev

Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsuanxyz @vthinkxie @wzhudev