-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:table): fix table fixed style when nzData change #4274
Conversation
Deploy preview for ng-zorro-master ready! Built with commit 0ccba78 |
Codecov Report
@@ Coverage Diff @@
## master #4274 +/- ##
==========================================
- Coverage 92.18% 92.17% -0.01%
==========================================
Files 520 520
Lines 10991 10994 +3
Branches 1990 1992 +2
==========================================
+ Hits 10132 10134 +2
Misses 430 430
- Partials 429 430 +1
Continue to review full report at Codecov.
|
@@ -269,6 +271,11 @@ export class NzTableComponent<T = any> implements OnInit, AfterViewInit, OnDestr | |||
this.fitScrollBar(); | |||
this.setScrollPositionClassName(); | |||
} | |||
if (changes.nzData) { | |||
if (this.platform.isBrowser) { | |||
setTimeout(() => this.setScrollPositionClassName()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
close #4253
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information