fix(module:table): fix table fixed style when nzData change #4274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit 0ccba78 |
Codecov Report
@@ Coverage Diff @@
## master #4274 +/- ##
==========================================
- Coverage 92.18% 92.17% -0.01%
==========================================
Files 520 520
Lines 10991 10994 +3
Branches 1990 1992 +2
==========================================
+ Hits 10132 10134 +2
Misses 430 430
- Partials 429 430 +1
Continue to review full report at Codecov.
|
Svetomechc
reviewed
Oct 16, 2019
| @@ -269,6 +271,11 @@ export class NzTableComponent<T = any> implements OnInit, AfterViewInit, OnDestr | |||
| this.fitScrollBar(); | |||
| this.setScrollPositionClassName(); | |||
| } | |||
| if (changes.nzData) { | |||
| if (this.platform.isBrowser) { | |||
| setTimeout(() => this.setScrollPositionClassName()); | |||
There was a problem hiding this comment.
This breaks the table for me for some reason:
8.3.0:
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4253
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information