Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline with nzPending and nzReverse borken if initiated with nzReverse=true #4509

Closed
whittssg opened this issue Dec 4, 2019 · 1 comment · Fixed by #4690
Closed

Timeline with nzPending and nzReverse borken if initiated with nzReverse=true #4509

whittssg opened this issue Dec 4, 2019 · 1 comment · Fixed by #4690

Comments

@whittssg
Copy link

whittssg commented Dec 4, 2019

Reproduction link

https://stackblitz.com/edit/angular-svfa4s?file=src/app/app.component.ts

Steps to reproduce

If you set reverse = false in the component (like in the docs) then the nzPending shows correctly, flipping it with the button so that reverse = true after its loaded also shows it correctly. Setting reverse = true at the beginning causes strange behavior.

What is expected?

to be able to set nzReverse to true from the start

What is actually happening?

Setting nzReverse to true from the start causes the component to look strange (nzPending is still at the bottom but all messed up).

Environment Info
ng-zorro-antd 8.5.2
Browser Chrome Latest 64bit
@zorro-bot
Copy link

zorro-bot bot commented Dec 30, 2019

Hello @whittssg. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please fill the Pull Request Template here, provide documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @whittssg, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请务必填写 Pull Request 内的预设模板,提供改动所需相应的测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!
giphy

wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this issue Jan 15, 2020
wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this issue Jan 18, 2020
wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this issue Feb 19, 2020
hsuanxyz pushed a commit that referenced this issue Feb 28, 2020
* fix(module:timeline): fix reverse bug

* fix: fix test

* chore: cleanup code

* fix: some consts

* test: refactor test

close #4509
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
* fix(module:timeline): fix reverse bug

* fix: fix test

* chore: cleanup code

* fix: some consts

* test: refactor test

close NG-ZORRO#4509
@hsuanxyz hsuanxyz mentioned this issue Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
* fix(module:timeline): fix reverse bug

* fix: fix test

* chore: cleanup code

* fix: some consts

* test: refactor test

close NG-ZORRO#4509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants